-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed translation configuration #237
Fixed translation configuration #237
Conversation
f1efc5d
to
ff08a72
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
], | ||
'output_dir' => __DIR__ . '/../Resources/translations/', | ||
'output_format' => 'xliff', | ||
'output_format' => 'xlf', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we are changing output format to xlf ?
], | ||
'output_dir' => __DIR__ . '/../Resources/translations/', | ||
'output_format' => 'xliff', | ||
'output_format' => 'xlf', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xliff
@adamwojs , @kisztof This pull request tries to revert/cleanup changes introduced in #184. All existing translations before this pull request were in |
a46580c
to
f19d065
Compare
d946511
to
88d052f
Compare
f19d065
to
9201602
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
* Fixed file visitor for extracting exception messages * Fixed translation configuration (#237)
v4.5
Fixes a path from which translations will be extracted and an extension of generated files.
Checklist:
$ composer fix-cs
).@ibexa/engineering
).