-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-1187: Link to example vhost file #1466
Conversation
DominikaK
commented
Oct 7, 2021
Question | Answer |
---|---|
JIRA Ticket | https://issues.ibexa.co/browse/IBX-1187 |
Versions | 3.3, master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The readme for ibexa/docker says:
Unsupported docker building blocks used for some of our automated functional testing infrastructure at Ibexa, feel free to copy it for own use or look to it for some recommended settings.
I feel like there should be a better place for this template, not in an unsupported repository 🙃
@mnocon Hm, but is the file itself acceptable? Then we can copy it to the doc repo. |
@DominikaK Yes, the file is fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of nitpicks
Require all granted | ||
</Directory> | ||
|
||
## eZ Platform/Symfony ENVIRONMENT variables, for customizing index.php* execution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change it to Ibexa DXP? There is also a second occurance in line below