Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-1187: Link to example vhost file #1466

Merged
merged 4 commits into from
Oct 12, 2021
Merged

IBX-1187: Link to example vhost file #1466

merged 4 commits into from
Oct 12, 2021

Conversation

DominikaK
Copy link
Contributor

Question Answer
JIRA Ticket https://issues.ibexa.co/browse/IBX-1187
Versions 3.3, master

Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The readme for ibexa/docker says:

Unsupported docker building blocks used for some of our automated functional testing infrastructure at Ibexa, feel free to copy it for own use or look to it for some recommended settings.

I feel like there should be a better place for this template, not in an unsupported repository 🙃

@DominikaK
Copy link
Contributor Author

@mnocon Hm, but is the file itself acceptable? Then we can copy it to the doc repo.

@mnocon
Copy link
Contributor

mnocon commented Oct 7, 2021

@DominikaK Yes, the file is fine

@DominikaK DominikaK requested a review from mnocon October 8, 2021 11:04
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nitpicks

code_samples/install/vhost_template/vhost.template Outdated Show resolved Hide resolved
Require all granted
</Directory>

## eZ Platform/Symfony ENVIRONMENT variables, for customizing index.php* execution
Copy link
Contributor

@mnocon mnocon Oct 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change it to Ibexa DXP? There is also a second occurance in line below

@juskora juskora self-assigned this Oct 12, 2021
@DominikaK DominikaK merged commit 1c263d0 into 3.3 Oct 12, 2021
@DominikaK DominikaK deleted the vhost branch October 12, 2021 09:54
DominikaK pushed a commit that referenced this pull request Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants