-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-3465: Added Nginx vhost template #1704
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rationale for copying the files here was that the docker repo is unsupported, so I guess copying both files makes most sense.
In that case, should we copy over the 6 extra params files, as well? |
Copying over is imperfect, ideally we should have a separate repo with this (I guess there could be other "resources" like this for the whole system), and keeping it in doc risks that the files will not be updated. |
What about ibexa/post-install? Why not there? |
So adding "apache" and "nginx" dirs with vhost examples under "resources" in ibexa/post-install? Sounds good to me. Ref. https://github.com/ibexa/post-install/tree/main/resources What do the package maintainers there say about that? @Nattfarinn @webhdx @adamwojs |
Post-release ping :)
|
It makes sense to move them to ibexa/post-install. We should also make a command for generating vhosts. I remember we had a bash script back in a day: https://github.com/ezsystems/ezplatform/blob/master/bin/vhost.sh |
Thanks. I copied the templates in ibexa/post-install#50 |
33f6b7e
to
2b50cbd
Compare
Co-authored-by: DominikaK <dominika.kurek@ez.no>
d900453
to
4839c48
Compare
It's necromancy time! 🦹♂️💀 So it makes sense to
Agree? |
@glye: Yes, Almost yes and Yes :) I'm all for removing the template file from this repo, but it's also referred to in https://github.com/ezsystems/developer-documentation/blob/master/docs/infrastructure_and_maintenance/environments.md and https://github.com/ezsystems/developer-documentation/blob/master/docs/infrastructure_and_maintenance/security/security_checklist.md. Can you update links in those two as well? |
Bunch of changes:
|
I've added one commit moving the two sections, Apache and nginx, into tabs for better viewing. |
@DominikaK Right, that sounds good. 👍 |
Like #1466 but for Nginx.
Sample vhost copied from https://github.com/ibexa/docker/blob/main/templates/nginx/vhost.template and Ibexified.
NB: It refers to files in ez_params.d, meaning in https://github.com/ibexa/docker/tree/main/templates/nginx/ez_params.d
Should we copy them over, too?
Alternatively, should we just link directly to the vhost file in the docker repo and not copy anything over?