Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added translation configuration #64

Merged
merged 1 commit into from
Aug 26, 2023
Merged

Added translation configuration #64

merged 1 commit into from
Aug 26, 2023

Conversation

mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented May 17, 2023 •
edited
Loading

Question Answer
JIRA issue N/A
Type improvement
Target version Ibexa v4.5
BC breaks no
Tests pass yes
Doc needed no
Needs ibexa/core#237

TODO:

  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@mikadamczyk mikadamczyk requested a review from a team May 17, 2023 08:22
@mikadamczyk mikadamczyk self-assigned this May 17, 2023
@mikadamczyk mikadamczyk changed the base branch from main to 4.4 May 17, 2023 08:24
@mikadamczyk mikadamczyk force-pushed the added_translation_configuration branch 3 times, most recently from a36563b to 21ef5a1 Compare May 17, 2023 08:36
adamwojs
adamwojs approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 besides code style issues

alongosz
alongosz approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Friendly reminder: CS is failing ;)

konradoboza
konradoboza approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case you forget: CS is failing. 😜

ViniTou
ViniTou approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@ViniTou ViniTou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems there are some code style issues, other than that LGTM

@mikadamczyk mikadamczyk force-pushed the added_translation_configuration branch 2 times, most recently from b80a9f2 to cf4feb5 Compare May 17, 2023 11:47
@sonarcloud
Copy link

sonarcloud bot commented May 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 28 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mikadamczyk mikadamczyk changed the base branch from 4.4 to 4.5 August 24, 2023 08:41
@mikadamczyk mikadamczyk force-pushed the added_translation_configuration branch from cf4feb5 to 01cdcb9 Compare August 24, 2023 08:49
@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adamwojs adamwojs merged commit 44b8769 into 4.5 Aug 26, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@alongosz alongosz alongosz approved these changes

@ViniTou ViniTou ViniTou approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@mikadamczyk mikadamczyk

@Steveb-p Steveb-p

@alongosz alongosz

@ViniTou ViniTou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mikadamczyk @adamwojs @alongosz @ViniTou @konradoboza @Steveb-p