Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: permissions on xcall connection #689

Merged
merged 3 commits into from
Sep 7, 2023

Conversation

gcranju
Copy link
Collaborator

@gcranju gcranju commented Sep 1, 2023

Description:

Commit Message

fix: permissions on xcall connection

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2023

Codecov Report

Merging #689 (9226482) into main (e6d5089) will increase coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 75.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #689      +/-   ##
============================================
+ Coverage     69.03%   69.06%   +0.03%     
  Complexity      406      406              
============================================
  Files           152      152              
  Lines         13836    13836              
  Branches        290      290              
============================================
+ Hits           9551     9556       +5     
+ Misses         4133     4128       -5     
  Partials        152      152              
Flag Coverage Δ
rust 67.07% <75.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../cosmwasm-vm/cw-common/src/xcall_connection_msg.rs 40.00% <ø> (ø)
...osmwasm-vm/cw-xcall-ibc-connection/src/contract.rs 53.82% <50.00%> (ø)
...s/cosmwasm-vm/cw-xcall-ibc-connection/src/admin.rs 98.55% <100.00%> (ø)
...-xcall-ibc-connection/src/types/config_response.rs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@gcranju gcranju added bug Something isn't working Archway Archway Chain related task Audit Issue Issues discovered in security audit labels Sep 5, 2023
@ibrizsabin ibrizsabin merged commit 58d43c7 into main Sep 7, 2023
14 of 15 checks passed
@ibrizsabin ibrizsabin deleted the 236-permissions-on-xcall-connection branch September 7, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Archway Archway Chain related task Audit Issue Issues discovered in security audit bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants