fix: permissions on xcall connection

contracts/cosmwasm-vm/cw-common/src/xcall_connection_msg.rs

@@ -64,7 +64,6 @@ pub enum ExecuteMsg {
     },
 }
 
-
 #[cw_serde]
 pub struct ConfigResponse {
     pub channel_id: String,

contracts/cosmwasm-vm/cw-xcall-ibc-connection/src/admin.rs

@@ -101,7 +101,7 @@ impl<'a> CwIbcConnection<'a> {
             });
         }
 
-        self.ensure_owner(store, &info)?;
+        self.ensure_admin(store, info.sender)?;
 
         self.admin()
             .update(store, |mut current_admin| -> Result<_, ContractError> {

contracts/cosmwasm-vm/cw-xcall-ibc-connection/src/contract.rs

@@ -17,9 +17,8 @@ use crate::{
         XCALL_HANDLE_ERROR_REPLY_ID, XCALL_HANDLE_MESSAGE_REPLY_ID,
     },
     types::{
-        channel_config::ChannelConfig, config::Config, connection_config::ConnectionConfig,
-        config_response::to_config_response,
-        message::Message, LOG_PREFIX,
+        channel_config::ChannelConfig, config::Config, config_response::to_config_response,
+        connection_config::ConnectionConfig, message::Message, LOG_PREFIX,
     },
 };
 
@@ -107,7 +106,7 @@ impl<'a> CwIbcConnection<'a> {
                 self.send_message(deps, info, env, to, sn, msg)
             }
             ExecuteMsg::SetXCallHost { address } => {
-                self.ensure_owner(deps.as_ref().storage, &info)?;
+                self.ensure_admin(deps.as_ref().storage, info.sender)?;
                 let validated_address =
                     CwIbcConnection::validate_address(deps.api, address.as_str())?;
                 self.set_xcall_host(deps.storage, validated_address)?;
@@ -120,7 +119,7 @@ impl<'a> CwIbcConnection<'a> {
                 client_id,
                 timeout_height,
             } => {
-                self.ensure_owner(deps.as_ref().storage, &info)?;
+                self.ensure_admin(deps.as_ref().storage, info.sender)?;
                 self.configure_connection(
                     deps.storage,
                     connection_id,

contracts/cosmwasm-vm/cw-xcall-ibc-connection/src/types/config_response.rs

@@ -1,7 +1,7 @@
 use cw_common::xcall_connection_msg::ConfigResponse;
 
-use crate::types::channel_config::ChannelConfig;
 use crate::state::IbcConfig;
+use crate::types::channel_config::ChannelConfig;
 
 pub fn to_config_response(ibc_config: IbcConfig, channel_config: ChannelConfig) -> ConfigResponse {
     ConfigResponse {
@@ -12,4 +12,4 @@ pub fn to_config_response(ibc_config: IbcConfig, channel_config: ChannelConfig)
         light_client_id: channel_config.client_id,
         timeout_height: channel_config.timeout_height.clone(),
     }
-}
+}

contracts/cosmwasm-vm/cw-xcall-ibc-connection/src/types/mod.rs

@@ -2,8 +2,8 @@ pub mod storage_keys;
 pub use common::rlp;
 
 pub mod channel_config;
-pub mod config_response;
 pub mod config;
+pub mod config_response;
 pub mod connection_config;
 pub mod message;
 pub mod network_fees;

contracts/cosmwasm-vm/cw-xcall-ibc-connection/tests/test_admin.rs

@@ -54,7 +54,7 @@ fn add_admin() {
 }
 
 #[test]
-#[should_panic(expected = "Unauthorized")]
+#[should_panic(expected = "OnlyAdmin")]
 fn update_admin_unauthorzied() {
     let mut mock_deps = deps();
 
@@ -113,6 +113,8 @@ fn update_admin() {
 
     assert_eq!(result, admin_one().to_string());
 
+    let mock_info = create_mock_info(&admin_one().to_string(), "umlg", 2000);
+
     contract
         .update_admin(
             mock_deps.as_mut().storage,
@@ -151,6 +153,8 @@ fn update_existing_admin() {
 
     assert_eq!(result, admin_one().to_string());
 
+    let mock_info = create_mock_info(&admin_one().to_string(), "umlg", 2000);
+
     contract
         .update_admin(
             mock_deps.as_mut().storage,

contracts/cosmwasm-vm/cw-xcall-ibc-connection/tests/test_ibc_functions.rs

@@ -817,7 +817,7 @@ fn success_on_setting_timeout_height() {
 }
 
 #[test]
-#[should_panic(expected = "Unauthorized")]
+#[should_panic(expected = "OnlyAdmin")]
 fn fails_on_configure_connection_unauthorized() {
     let mut deps = deps();