Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensor naming convention #248

Merged
merged 3 commits into from
Jan 31, 2023
Merged

Add sensor naming convention #248

merged 3 commits into from
Jan 31, 2023

Conversation

Nicogene
Copy link
Member

As per title

cc @traversaro

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor refinements.

@pattacini pattacini merged commit b3592c4 into master Jan 31, 2023
@pattacini pattacini deleted the Nicogene-patch-1 branch January 31, 2023 14:55
@traversaro
Copy link
Member

traversaro commented Jan 31, 2023

Just a small caveat @pattacini :

Where link is the name of the part the sensor is attached to (e.g., head), type is the type of sensor (e.g., imu), and nr is a number starting from 0.

I would avoid to use part in this context, as part is typically either head, left_arm, right_arm, torso, etc etc while in this context link is the link (i.e. either head, chest, etc etc). The fact that head is both a link and a part does not help. :D

@pattacini
Copy link
Member

Correct!
I'll amend it straight on master.

@pattacini
Copy link
Member

See ff2f34a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants