-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Modifications to be its own class #9
Conversation
fyi @fabiodinatale |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@GrmanRodriguez @vvasco can we tag the version of the library before this PR as |
good idea @traversaro thanks |
I'm creating a tag |
In that case I'd say first accept #12 since it's non-breaking and adding it to the tag |
I agree. Then after that PR is accepted and merged, we can proceed with the tag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
PR #12 has been merged, so we can create the tag and then merge this PR too.
Great work @GrmanRodriguez !
This PR changes the way we write modifications in the
urdf-modifiers
library.Modification
is now a class part ofurdfModifiers.core
with methods for adding the different modifications.A constructor for creating this class from a section of an ini file has also been added.
Below some examples of the changes:
Previous way of creating modifications:
New method:
As you can see it is now clearer and the code is cleaner.
cc @CarlottaSartore