Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt HERON to use ravenframework #140

Merged
merged 9 commits into from
Apr 12, 2022

Conversation

dylanjm
Copy link
Collaborator

@dylanjm dylanjm commented Mar 31, 2022


Pull Request Description

What issue does this change request address?

Closes #141

What are the significant changes in functionality due to this change request?

There should be no changes in functionality. Only adapting code to use a new RAVEN feature.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
  • 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

@dylanjm dylanjm added the Do Not Merge PR is not ready for merging label Mar 31, 2022
@dgarrett622 dgarrett622 mentioned this pull request Apr 1, 2022
9 tasks
@dylanjm dylanjm added the priority-critical Task that is time sensitive and critical to project work label Apr 1, 2022
@moosebuild
Copy link
Collaborator

Job CentOS 8 on f3dee5e : invalidated by @PaulTalbot-INL

TEAL in RAVEN has been updated retesting

@dgarrett622
Copy link
Collaborator

Note that some tests may not pass now due to changes made in RAVEN PR#1780 to percentile and value at risk. The differences should be small, but some tests may need new gold files.

@PaulTalbot-INL PaulTalbot-INL mentioned this pull request Apr 7, 2022
9 tasks
@dylanjm
Copy link
Collaborator Author

dylanjm commented Apr 12, 2022

@PaulTalbot-INL All tests passed and diffs resolved. This is ready for a full review and merge.

@PaulTalbot-INL
Copy link
Collaborator

Checklist complete. Thanks for taking care of this, and sorry it took so much effort!

@PaulTalbot-INL PaulTalbot-INL merged commit 4e2700b into idaholab:devel Apr 12, 2022
@PaulTalbot-INL
Copy link
Collaborator

See idaholab/raven#1808 for submod update

@dylanjm dylanjm deleted the ravenframework-fix branch April 11, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge PR is not ready for merging priority-critical Task that is time sensitive and critical to project work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DEFECT] Adapt HERON to use RAVEN framework as a package
5 participants