Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HERON submod update #1808

Merged
merged 2 commits into from
Apr 15, 2022
Merged

Conversation

PaulTalbot-INL
Copy link
Collaborator

@PaulTalbot-INL PaulTalbot-INL commented Apr 12, 2022


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Continues #1114

What are the significant changes in functionality due to this change request?

Updates HERON to be compatible with ravenframework renaming and TEAL updates.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@dylanjm
Copy link
Collaborator

dylanjm commented Apr 12, 2022

@PaulTalbot-INL Do you want to merge idaholab/HERON#138 and idaholab/HERON#142 before we do the submodule update, or after? I don't have a preference either way.

@PaulTalbot-INL
Copy link
Collaborator Author

I think priority is getting this fix in; we can wait a little to see how the restarted tests go, and then update this if they pass. If they need any additional work, then I think we update the submod without waiting for new changes.

Thanks for checking on that.

@moosebuild
Copy link

Job Test qsubs sawtooth on fa08fbd : invalidated by @dylanjm

Try Qsubs again

@dylanjm
Copy link
Collaborator

dylanjm commented Apr 13, 2022

This is just waiting on #1807 before the qsubs should pass.

@moosebuild
Copy link

Job Test qsubs sawtooth on fa08fbd : invalidated by @PaulTalbot-INL

retesting after sawtooth fixes

@moosebuild
Copy link

Job Test qsubs sawtooth on fa08fbd : canceled by @joshua-cogliati-inl

This will fail because it is still running in sawtooth-gnu

@moosebuild
Copy link

Job Test qsubs sawtooth on b26fc47 : invalidated by @joshua-cogliati-inl

FAILED: Diff tests/cluster_tests/RavenRunsRaven/Code

@dylanjm dylanjm merged commit afb598f into idaholab:devel Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants