Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug mode #89

Merged
merged 10 commits into from
Jun 8, 2021
Merged

Debug mode #89

merged 10 commits into from
Jun 8, 2021

Conversation

PaulTalbot-INL
Copy link
Collaborator

@PaulTalbot-INL PaulTalbot-INL commented Jun 8, 2021


Pull Request Description

What issue does this change request address?

Closes #12

What are the significant changes in functionality due to this change request?

Adds a <debug> node option to the <Case> node in the input that activates:

  • Limited sampling
    • user-adjustable, but nominally one year, one cluster, 2 synthetic samples
  • Output of dispatch results at the outer level
    • in a NetCDF database
    • in a compound CSV
    • in HERON-specific plots

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
  • 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

PaulTalbot-INL and others added 10 commits February 23, 2021 12:33
* Initial Commit for Plotting Templates

* Install infrastructure to handle debug plots.

This commit now appropriatley automates adding plot specific nodes to the
outer.xml files

* Add DispatchPlot to __init__.py

* Add boilerplat for dispatch plots

* Add initial plotting scheme

* Change plot save name

* Loop through RAVEN_sample_ID and YEAR variables

* Add documentation and loop through _ROM_Cluster

* Address PR comments

* Address comments
@PaulTalbot-INL PaulTalbot-INL requested a review from dylanjm June 8, 2021 14:51
Copy link
Collaborator

@dylanjm dylanjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. The logic, documentation, and tests follow all the proper standards. I'll go ahead and merge this. Thanks!

@dylanjm dylanjm merged commit dd70552 into idaholab:devel Jun 8, 2021
@PaulTalbot-INL PaulTalbot-INL deleted the debug_mode branch January 31, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output Dispatcher results
2 participants