Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework location work #47

Merged
merged 7 commits into from
Apr 1, 2022
Merged

Framework location work #47

merged 7 commits into from
Apr 1, 2022

Conversation

joshua-cogliati-inl
Copy link
Collaborator

@joshua-cogliati-inl joshua-cogliati-inl commented Mar 1, 2022


Pull Request Description

What issue does this change request address?

idaholab/raven#1764

What are the significant changes in functionality due to this change request?

Changes the raven framework directory imports and uses to the new ravenframework from framework.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
  • 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

@joshua-cogliati-inl joshua-cogliati-inl added the Do Not Merge Pull request should not be merged. label Mar 1, 2022
@joshua-cogliati-inl
Copy link
Collaborator Author

This is Do Not Merge until RAVEN switches to being inside the framework package. (Current RAVEN pull request is: idaholab/raven#1748 )

@joshua-cogliati-inl joshua-cogliati-inl removed the Do Not Merge Pull request should not be merged. label Mar 31, 2022
@moosebuild
Copy link

Job CentOS 8 on 2e583e2 : invalidated by @joshua-cogliati-inl

Checking with updated raven.

@joshua-cogliati-inl
Copy link
Collaborator Author

@PaulTalbot-INL or @worseliz This is ready for review.

from .src import CashFlow_ExtMod
from .src import CashFlows
from .src import CashFlowUser
from .src import main as CashFlow
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshua-cogliati-inl do we need to add the raven dir to the system path here so python knows about ravenframework?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, considering we have to adjust the python path to find __init__.py for TEAL, we can probably just add both the RAVEN path and the TEAL path at the same time before we get to this file.

Copy link
Collaborator

@dylanjm dylanjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. No required documentation changes or functionality. This PR is required before idaholab/HERON#140 can be merged.

@dylanjm dylanjm merged commit 500f1ac into devel Apr 1, 2022
@PaulTalbot-INL PaulTalbot-INL deleted the framework_loc_work branch April 4, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants