-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Framework location work #47
Conversation
This is Do Not Merge until RAVEN switches to being inside the framework package. (Current RAVEN pull request is: idaholab/raven#1748 ) |
Job CentOS 8 on 2e583e2 : invalidated by @joshua-cogliati-inl Checking with updated raven. |
5809a77
to
e8132be
Compare
@PaulTalbot-INL or @worseliz This is ready for review. |
from .src import CashFlow_ExtMod | ||
from .src import CashFlows | ||
from .src import CashFlowUser | ||
from .src import main as CashFlow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshua-cogliati-inl do we need to add the raven dir to the system path here so python knows about ravenframework?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, considering we have to adjust the python path to find __init__.py
for TEAL, we can probably just add both the RAVEN path and the TEAL path at the same time before we get to this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me. No required documentation changes or functionality. This PR is required before idaholab/HERON#140 can be merged.
Pull Request Description
What issue does this change request address?
idaholab/raven#1764
What are the significant changes in functionality due to this change request?
Changes the raven framework directory imports and uses to the new ravenframework from framework.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.