Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEFECT] Datasets unable to handle multiple values at the same time. (e.g. events in Modelica for example) #1360

Closed
10 tasks done
klfrick2 opened this issue Oct 29, 2020 · 0 comments · Fixed by #1366
Closed
10 tasks done
Labels
defect priority_normal RAVENv2.1 All tasks and defects that will go in RAVEN v2.1

Comments

@klfrick2
Copy link

klfrick2 commented Oct 29, 2020


Defect Description

Describe the defect
In the Code Interface for the bouncing ball. The test was created with the values test_Dymola_code_interface_timedep.xml if multiple monte carlo seeds are attempted in the ensemble model.

What did you expect to see happen?

I would expect to be able to collapse a dataset based on the timesteps given out by the code.

What did you see instead?

An error saying the dataset cannot be collapsed along the time variable as

Do you have a suggested fix for the development team?

Not clear. I think Andrea mentioned the possibility of moderately editing the time variable on a relative basis of 1e-4. (e.g. if there are two steps at time 0.1seconds then the first one would be 0.1 and the second would be 0.10001. Not changing the trajectory, but giving the dataset multiple values to pivot along.

Describe how to Reproduce
Steps to reproduce the behavior:

  1. Have a running version of Modelica on the machine.
  2. Unzip the file.
  3. Update the test_Dymola_code_interface_timedep.xml to point to the proper executables.
  4. Try and run.

Screenshots and Input Files
Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.

DMInterfaceTestTimedep.zip

Platform (please complete the following information):
Windows 10.


For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
alfoa added a commit that referenced this issue Nov 3, 2020
@alfoa alfoa mentioned this issue Nov 3, 2020
9 tasks
joshua-cogliati-inl pushed a commit that referenced this issue Dec 8, 2020
* added interface for acc CDF

* now code interfaces can return data in finalizeCodeOutput directly

* modified RELAP5 interface to avoid CSV creation from the interface

* updated Dymola, RELAP5 and MELCOR

* modified Cobra Interface for no CSV finalizeOutput

* Closes #1360

* Closes #1274

* added projectile no csv

* finalized interface

* added interface for accelerated CFD

* new files

* fix dymolainterface

* update rounding error for time index

* fixed 3 tests over 4

* regolded melcor test since there was a bug in the previous prcsv printing (in the interface) that was skipping the last time step (10000)

* reformatedd accelerate cfd interface

* drafted manual AccCFD

* removed accelerate cfd...not belgons here

* the writeCsv optional is now handled at the CodeInterface Level

* added dataobject ot check that the operators are part of the input

* added gc collection in plots

* Update ProjectileInterfaceNoCSV.py

* Update randomUtils.py
@alfoa alfoa added the RAVENv2.1 All tasks and defects that will go in RAVEN v2.1 label Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect priority_normal RAVENv2.1 All tasks and defects that will go in RAVEN v2.1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants