Alfoa/codeinterfaces #1366
Merged
Alfoa/codeinterfaces #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding ability to sign the .so files. (#1362) Adding ability to sign the .so files.. This will be needed in future mac os releases. * debug * fix dymolainterface * revert code interface changes * update rounding error for time index * fix index for duplicated values Co-authored-by: Joshua J. Cogliati <joshua-cogliati-inl@users.noreply.github.com>
…ting (in the interface) that was skipping the last time step (10000)
joshua-cogliati-inl
requested changes
Dec 3, 2020
framework/CodeInterfaces/WorkshopExamples/ProjectileInterfaceNoCSV.py
Outdated
Show resolved
Hide resolved
tests/framework/pca_LHS/gold/stratifiedCdf/testPrintPointSet_dump.csv
Outdated
Show resolved
Hide resolved
|
@joshua-cogliati-inl I addressed your comments. |
Thanks, I'll take a look today. |
joshua-cogliati-inl
approved these changes
Dec 7, 2020
|
|
||
| # in general, we will use Crow for now, but let's make it easy to switch just in case it is helpful eventually. | ||
| # in general, we will use Crow for now, but let's make it easy to switch just in case it is helpfull eventually. |
There was a problem hiding this comment.
For what it is worth, helpful is the more standard spelling.
| @@ -41,7 +41,7 @@ | |||
| 2500000 inlet tmdpvol | |||
| 2500101 1.0 1.0 0.0 0.0 0.0 0.0 0.0 0.0 0000000 | |||
| 2500200 003 | |||
| 2500201 0.0 6.39e+06 530.245239193 | |||
| 2500201 0.0 6.39e+06 5.30245e+02 | |||
There was a problem hiding this comment.
Is this a comment or a piece of data that is used by Relap5?
|
Job Mingw Test on 2b61fd4 : invalidated by @joshua-cogliati-inl restarted civet |
|
When the tests pass, this is ready to go. |
|
Job Mingw Test on 2b61fd4 : invalidated by @joshua-cogliati-inl deleted raven directory |
|
Job Mingw Test on 2b61fd4 : invalidated by @joshua-cogliati-inl Failed tests\framework\CodeInterfaceTests\genericInterfaceParallel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #1360
Closes #1274
Closes #1079 (the duplicated values must be handled at the code interface level)
Closes #446
Closes #1367
What are the significant changes in functionality due to this change request?
Addition of the possibility to return the output data directly from the finalizeCodeOutput. In this way,
we avoid the double IO of
reading Code Output -> memory -> creation of CSV -> RAVEN reading the CSV -> output in memory
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>to True.raven/tests/framework/user_guideandraven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.