Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOOSE Input Drops Text After Second '=' #792

Closed
10 tasks done
elementx54 opened this issue Sep 17, 2018 · 2 comments · Fixed by #793
Closed
10 tasks done

MOOSE Input Drops Text After Second '=' #792

elementx54 opened this issue Sep 17, 2018 · 2 comments · Fixed by #793

Comments

@elementx54
Copy link
Contributor

elementx54 commented Sep 17, 2018


Issue Description

What did you expect to see happen?

I expected function = 'alpha := total_volume * current_power_density * (1 - tau); beta := tau * current_power_density; alpha * beta' in my moose input file to be parsed to the same thing when it spawned all the jobs.

What did you see instead?

Instead it dropped all the text after the second = putting in the new input file function = 'alpha : causing the run to error.

Do you have a suggested fix for the development team?

I do! Expect a merge request soon. 😃 And it is running now with the fix.

Please attach the input file(s) that generate this error. The simpler the input, the faster we can find the issue.

For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or improvement?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest stable branch? If yes, is there any issue tagged with stable (create if needed)?
  • 5. If the issue is being closed without a merge request, has an explanation of why it is being closed been provided?
elementx54 pushed a commit to elementx54/raven that referenced this issue Sep 17, 2018
idaholab#792

The MOOSE input line is now only split once with the left most `=` being
used.

Closes idaholab#792
@PaulTalbot-INL
Copy link
Collaborator

PaulTalbot-INL commented Sep 17, 2018

No email needed since it only crashes if the problem is discovered instead of giving an incorrect value. Approved for development.

elementx54 pushed a commit to elementx54/raven that referenced this issue Sep 21, 2018
idaholab#792

The MOOSE input line is now only split once with the left most `=` being
used.

Edit: Code Interface Test Added

Closes idaholab#792
@PaulTalbot-INL
Copy link
Collaborator

Defect is fixed, and not only does the implemented test check the fix, it furthermore checks the entire mechanics for the MOOSE input parser writing. Approved for closure via merging #794.

elementx54 pushed a commit to elementx54/raven that referenced this issue Sep 27, 2018
idaholab#792

The MOOSE input line is now only split once with the left most `=` being
used.

Edit: Code Interface Test Added
Edit: Removed the not needed `out~MOOSE_parser` files

Closes idaholab#792
alfoa pushed a commit that referenced this issue Oct 23, 2018
#792

The MOOSE input line is now only split once with the left most `=` being
used.

Edit: Code Interface Test Added
Edit: Removed the not needed `out~MOOSE_parser` files

Closes #792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants