Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One split per line for MOOSE inputs. #793

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

elementx54
Copy link
Contributor

@elementx54 elementx54 commented Sep 17, 2018


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

#792

What are the significant changes in functionality due to this change request?

The MOOSE input line is now only split once with the left most = being
used.

Closes #792


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?

@PaulTalbot-INL
Copy link
Collaborator

This PR needs a new test (or extension of an existing test) that demonstrates capturing the new behavior.

@elementx54
Copy link
Contributor Author

There is no test to check MOOSE input files for parsing them correctly, so I couldn't modify an existing test to include multiple equal signs.

@elementx54 elementx54 force-pushed the parse_function_moose_input branch from 2765b41 to 57a8157 Compare September 21, 2018 18:06
@elementx54
Copy link
Contributor Author

Edit: Added the interface check that didn't exist and made sure the multiple equal signs problem was in the input file.

Should be ready to merge (if it passes).

idaholab#792

The MOOSE input line is now only split once with the left most `=` being
used.

Edit: Code Interface Test Added
Edit: Removed the not needed `out~MOOSE_parser` files

Closes idaholab#792
@elementx54 elementx54 force-pushed the parse_function_moose_input branch from 57a8157 to 271d392 Compare September 27, 2018 17:11
@elementx54
Copy link
Contributor Author

I've amended the commit with the requested changes (the two files are gone), and it is ready to restart the tests.

@elementx54
Copy link
Contributor Author

So the OpenSUSE Tumbleweed test failed because it was never ran. Am I reading that correctly?

@alfoa
Copy link
Collaborator

alfoa commented Oct 15, 2018

yes

@elementx54
Copy link
Contributor Author

Ah, so can you re-run that one since it looks like that is the only thing holding up this request? I don't think I can tell it to re-run.

@PaulTalbot-INL
Copy link
Collaborator

Actually, the Tumbleweed test is allowed-to-fail and will be discontinued. This is ready to be merged when changes are approved by Andrea, as I see it.

@alfoa
Copy link
Collaborator

alfoa commented Oct 23, 2018

Checklist passed...

Merging...

@alfoa alfoa merged commit fed1b1c into idaholab:devel Oct 23, 2018
@elementx54 elementx54 deleted the parse_function_moose_input branch December 19, 2018 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MOOSE Input Drops Text After Second '='
3 participants