-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One split per line for MOOSE inputs. #793
Conversation
This PR needs a new test (or extension of an existing test) that demonstrates capturing the new behavior. |
There is no test to check MOOSE input files for parsing them correctly, so I couldn't modify an existing test to include multiple equal signs. |
2765b41
to
57a8157
Compare
Edit: Added the interface check that didn't exist and made sure the multiple equal signs problem was in the input file. Should be ready to merge (if it passes). |
tests/framework/CodeInterfaceTests/MOOSEparser/parser_moose/2/out~MOOSE_parser
Outdated
Show resolved
Hide resolved
tests/framework/CodeInterfaceTests/MOOSEparser/parser_moose/1/out~MOOSE_parser
Outdated
Show resolved
Hide resolved
tests/framework/CodeInterfaceTests/MOOSEparser/parser_moose/2/out~MOOSE_parser.csv
Show resolved
Hide resolved
idaholab#792 The MOOSE input line is now only split once with the left most `=` being used. Edit: Code Interface Test Added Edit: Removed the not needed `out~MOOSE_parser` files Closes idaholab#792
57a8157
to
271d392
Compare
I've amended the commit with the requested changes (the two files are gone), and it is ready to restart the tests. |
So the OpenSUSE Tumbleweed test failed because it was never ran. Am I reading that correctly? |
yes |
Ah, so can you re-run that one since it looks like that is the only thing holding up this request? I don't think I can tell it to re-run. |
Actually, the Tumbleweed test is allowed-to-fail and will be discontinued. This is ready to be merged when changes are approved by Andrea, as I see it. |
Checklist passed... Merging... |
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
#792
What are the significant changes in functionality due to this change request?
The MOOSE input line is now only split once with the left most
=
beingused.
Closes #792
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.