Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from nccgroup:master #14

Open
wants to merge 1,248 commits into
base: master
Choose a base branch
from
Open

[pull] master from nccgroup:master #14

wants to merge 1,248 commits into from

Conversation

pull[bot]
Copy link

@pull pull bot commented Oct 1, 2020

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

@pull pull bot added the 🤖 ⤵️ pull label Oct 1, 2020
@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #14 (ad3b8fb) into master (d727fc0) will decrease coverage by 42.22%.
The diff coverage is 17.50%.

❗ Current head ad3b8fb differs from pull request most recent head 4300fc0. Consider uploading reports for the commit 4300fc0 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #14       +/-   ##
===========================================
- Coverage   66.25%   24.02%   -42.23%     
===========================================
  Files          22      319      +297     
  Lines        1547    10537     +8990     
===========================================
+ Hits         1025     2532     +1507     
- Misses        522     8005     +7483     
Impacted Files Coverage Δ
ScoutSuite/__main__.py 15.27% <0.00%> (-3.08%) ⬇️
ScoutSuite/core/cli_parser.py 84.34% <ø> (+0.86%) ⬆️
ScoutSuite/core/fs.py 96.42% <ø> (+24.49%) ⬆️
ScoutSuite/core/utils.py 85.71% <0.00%> (-0.34%) ⬇️
ScoutSuite/providers/aliyun/facade/kms.py 0.00% <0.00%> (ø)
ScoutSuite/providers/aliyun/facade/utils.py 0.00% <0.00%> (ø)
ScoutSuite/providers/aliyun/provider.py 0.00% <0.00%> (ø)
ScoutSuite/providers/aliyun/resources/ecs/base.py 0.00% <0.00%> (ø)
...tSuite/providers/aliyun/resources/ecs/instances.py 0.00% <0.00%> (ø)
ScoutSuite/providers/aliyun/resources/kms/base.py 0.00% <0.00%> (ø)
... and 460 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3b9d3d...4300fc0. Read the comment docs.

@pull pull bot added the merge-conflict Resolve conflicts manually label Oct 6, 2020
rdegraaf-ncc3 and others added 30 commits March 4, 2024 15:09
Apparently ScoutSuite makes the implicit assumption that all settings
are associated with resources, rather than directly to the region +
service. So we move the regional EBS settings into a fake resource.
This means that paths now need to include an ID for the "resource".
Review/Fixes for DigitalOcean to overwrite PR #1604
Fixed incompatible packages - Update requirements.txt
Update some GCP dependencies as in #1589 and pin protobuf 3.20.1 since more recent versions break GCP libs
Revert "Fixed incompatible packages - Update requirements.txt"
…-update

Bugfix/route53 domain lock update
…bac-disabled

Fixes 'Key Vault Role Based Access Control Disabled' check
…ontainer-labeling

Corrected display name for 'Blob Containers Allowing Public Access'
…-accounts-without-access-keys

Improves 'Access Keys Not Rotated' check
…used-credentials

 Bugfix/1621 Improve AWS unused credential issue flagging
…y-rotation-rule-name

Improves iam-user-no-key-rotation rule
…tail-view-highlighting

Adds highlighting for "EBS Volume Not Encrypted" detail view
Update to v5.14.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-conflict Resolve conflicts manually 🤖 ⤵️ pull
Projects
None yet
Development

Successfully merging this pull request may close these issues.