chore: enable errcheck linter

[faddat]

• adds errcheck linter

Description

This PR fixes a bug in how flag tests are handled. Since we're now checking if the test runs return error, we are able to see that flag tests have been failing because they don't include a value.

Link to earlier issue

I think that this PR shows the same behavior showed in #4074. Specifically, It set off the race detector. I don't think that is because of the linting changes. The difference between:

• 182a724

and

• a9bfcc5

is intentionally just a single comment.

Running tests on ubuntu fails in the first commit, but passes in the second. So, what I'm suggesting here is that we should make a PR that runs the tests 10x against the current main branch. This will let us observe the tests and know if they are flaky.

But it doesn't seem to be related to the errcheck work. Here's the data race here:

• https://github.com/ignite/cli/actions/runs/9163340095/job/25192204307#step:5:172

That's from main. I think we should spend some additional time looking for data races.

---

Please make sure to check the following for your PR:

• This PR complies with the contributing guidelines.
• Reviewed "Files changed" and left comments if necessary
• Included relevant documentation changes.

Ignite CLI team only:

• I have updated the Unreleased section in the changelog.md for my changes.
• If the templates in ignite/templates/files have been changed, make
  sure that the change doesn't need to be reflected in the
  ignite/templates/files-* folders.

[faddat]

this will show the bug surfaced in #4156

[faddat]

• https://github.com/faddat/starport/blob/6a6617f5360e44f55bf2cddcfb30d6861b061a31/ignite/services/plugin/grpc/v1/interface_flag.go#L45

[Pantani]

LGMT!!! thanks for the contribution @faddat

Just one comment

[faddat]

I'll resolve conflicts later today

[Pantani]

Error: ../../pkg/cosmosgen/cosmosgen.go:133:15: b.Cleanup undefined (type cosmosbuf.Buf has no field or method Cleanup)

the cleanup method from the cosmosbuf pkg was removed