chore: enable errcheck linter

.golangci.yml

@@ -9,7 +9,7 @@ linters:
     - depguard
     - dogsled
     - dupword
-    # - errcheck
+    - errcheck
     - errchkjson
     - errorlint
     - exhaustive
@@ -19,12 +19,10 @@ linters:
     - godot
     - gofumpt
     - revive
-    # - gosec
     - gosimple
     - govet
     - grouper
     - ineffassign
-    # - interfacer
     - misspell
     - nakedret
     - nolintlint
@@ -40,8 +38,6 @@ linters:
     - unparam
     - misspell
     - forbidigo
-    # - wrapcheck
-    # - wsl
 
 linters-settings:
   gci:
@@ -70,7 +66,5 @@ linters-settings:
 issues:
   exclude-dirs:
     - ignite/ui
-  #   # timeout for analysis, e.g. 30s, 5m, default is 1m
-  #   timeout: 5m
   max-issues-per-linter: 0
   max-same-issues: 0

changelog.md

@@ -21,6 +21,8 @@
 
 ### Changes
 
+
+- [#4162](https://github.com/ignite/cli/pull/4162) Enable errcheck linter and fix a bug in the way we test flags
 - [#4159](https://github.com/ignite/cli/pull/4159) Enable gci linter
 - [#4157](https://github.com/ignite/cli/pull/4157) Upgrade golang to 1.22
 - [#4094](https://github.com/ignite/cli/pull/4094) Scaffolding a multi-index map using `ignite s map foo bar baz --index foobar,foobaz` is no longer supported. Use one index instead of use `collections.IndexedMap`.

ignite/cmd/completion.go

@@ -1,6 +1,7 @@
 package ignitecmd
 
 import (
+	"fmt"
 	"os"
 
 	"github.com/spf13/cobra"
@@ -13,20 +14,28 @@ func NewCompletionCmd() *cobra.Command {
 		Short: "Generates shell completion script.",
 		Run: func(cmd *cobra.Command, args []string) {
 			if len(args) == 0 {
-				cmd.Help()
+				if err := cmd.Help(); err != nil {
+					fmt.Fprintln(os.Stderr, "Error displaying help:", err)
+					os.Exit(1)
+				}
 				os.Exit(0)
 			}
+			var err error
 			switch args[0] {
 			case "bash":
-				cmd.Root().GenBashCompletion(os.Stdout)
+				err = cmd.Root().GenBashCompletion(os.Stdout)
 			case "zsh":
-				cmd.Root().GenZshCompletion(os.Stdout)
+				err = cmd.Root().GenZshCompletion(os.Stdout)
 			case "fish":
-				cmd.Root().GenFishCompletion(os.Stdout, true)
+				err = cmd.Root().GenFishCompletion(os.Stdout, true)
 			case "powershell":
-				cmd.Root().GenPowerShellCompletion(os.Stdout)
+				err = cmd.Root().GenPowerShellCompletion(os.Stdout)
 			default:
-				cmd.Help()
+				err = cmd.Help()
+			}
+			if err != nil {
+				fmt.Fprintln(os.Stderr, "Error generating completion script:", err)
+				os.Exit(1)
 			}
 		},
 	}

ignite/cmd/plugin_test.go

@@ -80,13 +80,13 @@ func TestLinkPluginCmds(t *testing.T) {
 			Use: "flaggy",
 			Flags: []*plugin.Flag{
 				{Name: "flag1", Type: plugin.FlagTypeString},
-				{Name: "flag2", Type: plugin.FlagTypeInt, DefaultValue: "0"},
+				{Name: "flag2", Type: plugin.FlagTypeInt, DefaultValue: "0", Value: "0"},
 			},
 		}
 	)
 
 	// helper to assert pluginInterface.Execute() calls
-	expectExecute := func(t *testing.T, ctx context.Context, p *mocks.PluginInterface, cmd *plugin.Command) {
+	expectExecute := func(t *testing.T, _ context.Context, p *mocks.PluginInterface, cmd *plugin.Command) {
 		t.Helper()
 		p.EXPECT().
 			Execute(

ignite/internal/plugin/testdata/execute_fail/go.mod

@@ -1,8 +1,8 @@
 module execute_fail
 
-go 1.21.1
+go 1.22
 
-toolchain go1.21.5
+toolchain go1.22.3
 
 require (
 	github.com/hashicorp/go-plugin v1.6.0
@@ -82,7 +82,6 @@ require (
 	github.com/xanzy/ssh-agent v0.3.3 // indirect
 	go.etcd.io/bbolt v1.3.9 // indirect
 	golang.org/x/crypto v0.22.0 // indirect
-	golang.org/x/exp v0.0.0-20240404231335-c0f41cb1a7a0 // indirect
 	golang.org/x/mod v0.17.0 // indirect
 	golang.org/x/net v0.24.0 // indirect
 	golang.org/x/sync v0.7.0 // indirect
@@ -95,5 +94,5 @@ require (
 	google.golang.org/grpc v1.63.2 // indirect
 	google.golang.org/protobuf v1.33.0 // indirect
 	gopkg.in/warnings.v0 v0.1.2 // indirect
-	gopkg.in/yaml.v2 v2.4.0 // indirect
+	gopkg.in/yaml.v3 v3.0.1 // indirect
 )

ignite/internal/plugin/testdata/execute_ok/go.mod

@@ -1,8 +1,8 @@
 module execute_ok
 
-go 1.21.1
+go 1.22
 
-toolchain go1.21.5
+toolchain go1.22.3
 
 require (
 	github.com/hashicorp/go-plugin v1.6.0
@@ -82,7 +82,6 @@ require (
 	github.com/xanzy/ssh-agent v0.3.3 // indirect
 	go.etcd.io/bbolt v1.3.9 // indirect
 	golang.org/x/crypto v0.22.0 // indirect
-	golang.org/x/exp v0.0.0-20240404231335-c0f41cb1a7a0 // indirect
 	golang.org/x/mod v0.17.0 // indirect
 	golang.org/x/net v0.24.0 // indirect
 	golang.org/x/sync v0.7.0 // indirect
@@ -95,5 +94,5 @@ require (
 	google.golang.org/grpc v1.63.2 // indirect
 	google.golang.org/protobuf v1.33.0 // indirect
 	gopkg.in/warnings.v0 v0.1.2 // indirect
-	gopkg.in/yaml.v2 v2.4.0 // indirect
+	gopkg.in/yaml.v3 v3.0.1 // indirect
 )

ignite/internal/tools/gen-cli-docs/main.go

@@ -72,7 +72,9 @@ func run() error {
 	}
 	defer cleanUp()
 	cmd.Flags().String(outFlag, ".", ".md file path to place Ignite CLI docs inside")
-	cmd.Flags().MarkHidden(outFlag)
+	if err := cmd.Flags().MarkHidden(outFlag); err != nil {
+		return err
+	}
 
 	// Run ExecuteC so cobra adds the completion command.
 	cmd, err = cmd.ExecuteC()

ignite/pkg/cosmosgen/cosmosgen.go

@@ -2,6 +2,7 @@ package cosmosgen
 
 import (
 	"context"
+	"fmt"
 	"os"
 	"path/filepath"
 	"strings"
@@ -137,7 +138,11 @@ func Generate(ctx context.Context, cacheStorage cache.Storage, appPath, protoDir
 		return err
 	}
 
-	defer b.Cleanup()
+	defer func() {
+		if err := b.Cleanup(); err != nil {
+			fmt.Println("Cleanup error:", err)
+		}
+	}()
 
 	g := &generator{
 		buf:                 b,

ignite/pkg/gomodule/gomodule.go

@@ -188,11 +188,10 @@ func FindModule(ctx context.Context, rootDir, path string) (Module, error) {
 
 	for dec.More() {
 		var m Module
-		if dec.Decode(&m); err != nil {
+		if err := dec.Decode(&m); err != nil {
 			if errors.Is(err, io.EOF) {
 				break
 			}
-
 			return Module{}, err
 		}
 

ignite/services/chain/init.go

@@ -229,10 +229,6 @@ func (c *Chain) IsInitialized() (bool, error) {
 	if _, err := os.Stat(gentxDir); os.IsNotExist(err) {
 		return false, nil
 	}
-	if err != nil {
-		// Return error on other error
-		return false, err
-	}
 
 	return true, nil
 }

ignite/services/plugin/grpc/v1/interface_flag.go

@@ -42,46 +42,60 @@ func (f *Flag) exportToFlagSet(fs *pflag.FlagSet) error {
 		}
 
 		fs.BoolP(f.Name, f.Shorthand, v, f.Usage)
-		fs.Set(f.Name, f.Value)
+		if err := fs.Set(f.Name, f.Value); err != nil {
+			return err
+		}
 	case Flag_TYPE_FLAG_INT:
 		v, err := strconv.Atoi(f.DefaultValue)
 		if err != nil {
 			return newDefaultFlagValueError(cobraFlagTypeInt, f.DefaultValue)
 		}
 
 		fs.IntP(f.Name, f.Shorthand, v, f.Usage)
-		fs.Set(f.Name, f.Value)
+		if err := fs.Set(f.Name, f.Value); err != nil {
+			return err
+		}
 	case Flag_TYPE_FLAG_UINT:
 		v, err := strconv.ParseUint(f.DefaultValue, 10, 64)
 		if err != nil {
 			return newDefaultFlagValueError(cobraFlagTypeUint, f.DefaultValue)
 		}
 
 		fs.UintP(f.Name, f.Shorthand, uint(v), f.Usage)
-		fs.Set(f.Name, f.Value)
+		if err := fs.Set(f.Name, f.Value); err != nil {
+			return err
+		}
 	case Flag_TYPE_FLAG_INT64:
 		v, err := strconv.ParseInt(f.DefaultValue, 10, 64)
 		if err != nil {
 			return newDefaultFlagValueError(cobraFlagTypeInt64, f.DefaultValue)
 		}
 
 		fs.Int64P(f.Name, f.Shorthand, v, f.Usage)
-		fs.Set(f.Name, f.Value)
+		if err := fs.Set(f.Name, f.Value); err != nil {
+			return err
+		}
 	case Flag_TYPE_FLAG_UINT64:
 		v, err := strconv.ParseUint(f.DefaultValue, 10, 64)
 		if err != nil {
 			return newDefaultFlagValueError(cobraFlagTypeInt64, f.DefaultValue)
 		}
 
 		fs.Uint64P(f.Name, f.Shorthand, v, f.Usage)
-		fs.Set(f.Name, f.Value)
+		if err := fs.Set(f.Name, f.Value); err != nil {
+			return err
+		}
 	case Flag_TYPE_FLAG_STRING_SLICE:
 		s := strings.Trim(f.DefaultValue, "[]")
 		fs.StringSliceP(f.Name, f.Shorthand, strings.Fields(s), f.Usage)
-		fs.Set(f.Name, strings.Trim(f.Value, "[]"))
+		if err := fs.Set(f.Name, strings.Trim(f.Value, "[]")); err != nil {
+			return err
+		}
 	case Flag_TYPE_FLAG_STRING_UNSPECIFIED:
 		fs.StringP(f.Name, f.Shorthand, f.DefaultValue, f.Usage)
-		fs.Set(f.Name, f.Value)
+		if err := fs.Set(f.Name, f.Value); err != nil {
+			return err
+		}
 	}
 	return nil
 }

ignite/services/plugin/grpc/v1/types_command_test.go

@@ -149,48 +149,55 @@ func TestExecutedCommandNewFlags(t *testing.T) {
 				Shorthand:    "b",
 				Usage:        "bool usage",
 				DefaultValue: "false",
+				Value:        "true",
 				Type:         v1.Flag_TYPE_FLAG_BOOL,
 			},
 			{
 				Name:         "int",
 				Shorthand:    "i",
 				Usage:        "int usage",
 				DefaultValue: "0",
+				Value:        "42",
 				Type:         v1.Flag_TYPE_FLAG_INT,
 			},
 			{
 				Name:         "uint",
 				Shorthand:    "u",
 				Usage:        "uint usage",
 				DefaultValue: "0",
+				Value:        "42",
 				Type:         v1.Flag_TYPE_FLAG_UINT,
 			},
 			{
 				Name:         "int64",
 				Shorthand:    "j",
 				Usage:        "int64 usage",
 				DefaultValue: "0",
+				Value:        "42",
 				Type:         v1.Flag_TYPE_FLAG_INT64,
 			},
 			{
 				Name:         "uint64",
 				Shorthand:    "k",
 				Usage:        "uint64 usage",
 				DefaultValue: "0",
+				Value:        "42",
 				Type:         v1.Flag_TYPE_FLAG_UINT64,
 			},
 			{
 				Name:         "string",
 				Shorthand:    "s",
 				Usage:        "string usage",
 				DefaultValue: "",
+				Value:        "hello",
 				Type:         v1.Flag_TYPE_FLAG_STRING_UNSPECIFIED,
 			},
 			{
 				Name:         "string-slice",
 				Shorthand:    "l",
 				Usage:        "string slice usage",
 				DefaultValue: "[]",
+				Value:        "[]",
 				Type:         v1.Flag_TYPE_FLAG_STRING_SLICE,
 			},
 			{
@@ -247,6 +254,7 @@ func TestExecutedCommandNewPersistentFlags(t *testing.T) {
 				Shorthand:    "b",
 				Usage:        "bool usage",
 				DefaultValue: "false",
+				Value:        "true",
 				Type:         v1.Flag_TYPE_FLAG_BOOL,
 				Persistent:   true,
 			},
@@ -255,6 +263,7 @@ func TestExecutedCommandNewPersistentFlags(t *testing.T) {
 				Shorthand:    "i",
 				Usage:        "int usage",
 				DefaultValue: "0",
+				Value:        "42",
 				Type:         v1.Flag_TYPE_FLAG_INT,
 				Persistent:   true,
 			},
@@ -263,6 +272,7 @@ func TestExecutedCommandNewPersistentFlags(t *testing.T) {
 				Shorthand:    "u",
 				Usage:        "uint usage",
 				DefaultValue: "0",
+				Value:        "42",
 				Type:         v1.Flag_TYPE_FLAG_UINT,
 				Persistent:   true,
 			},
@@ -271,6 +281,7 @@ func TestExecutedCommandNewPersistentFlags(t *testing.T) {
 				Shorthand:    "j",
 				Usage:        "int64 usage",
 				DefaultValue: "0",
+				Value:        "42",
 				Type:         v1.Flag_TYPE_FLAG_INT64,
 				Persistent:   true,
 			},
@@ -279,6 +290,7 @@ func TestExecutedCommandNewPersistentFlags(t *testing.T) {
 				Shorthand:    "k",
 				Usage:        "uint64 usage",
 				DefaultValue: "0",
+				Value:        "42",
 				Type:         v1.Flag_TYPE_FLAG_UINT64,
 				Persistent:   true,
 			},
@@ -287,6 +299,7 @@ func TestExecutedCommandNewPersistentFlags(t *testing.T) {
 				Shorthand:    "s",
 				Usage:        "string usage",
 				DefaultValue: "",
+				Value:        "hello",
 				Type:         v1.Flag_TYPE_FLAG_STRING_UNSPECIFIED,
 				Persistent:   true,
 			},
@@ -295,6 +308,7 @@ func TestExecutedCommandNewPersistentFlags(t *testing.T) {
 				Shorthand:    "l",
 				Usage:        "string slice usage",
 				DefaultValue: "[]",
+				Value:        "[]",
 				Type:         v1.Flag_TYPE_FLAG_STRING_SLICE,
 				Persistent:   true,
 			},