Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion of objects to/from other libraries #242

Merged
merged 17 commits into from
Jul 14, 2020

Conversation

iosonofabio
Copy link
Member

@iosonofabio iosonofabio commented Aug 19, 2019

This tries to address #237.

Done:

  • Graph to/from networkx
  • Graph to/from graph-tool
  • Multigraphs to/from networkx
  • Multigraphs to/from graph-tool

All these things include tests that pass locally. All tests on networkx pass on Travis too, but graph-tool is a pain to install there so that is not tested on CI.

This is ready for merging now

@stale
Copy link

stale bot commented Jan 31, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 31, 2020
@ntamas ntamas added todo Triaged for implementation in some unspecified future version and removed stale labels Jan 31, 2020
@ntamas ntamas added this to the 0.8.1 milestone Jan 31, 2020
@ntamas
Copy link
Member

ntamas commented Jan 31, 2020

FYI, this PR needs to be adjusted for the new directory structure (igraph moved under src).

@iosonofabio
Copy link
Member Author

I now adjusted the PR as requested and pulled in a fresh version of the master branch. I am puzzled by the failure on AppVeyor though, it doesn't appear to be obviously related to this particular PR?

@ntamas
Copy link
Member

ntamas commented Jul 13, 2020

Yes, that's unrelated, it is also present on the master branch. I have to look into this at some point, I just haven't found the time to do so yet.

@ntamas ntamas merged commit afe2230 into igraph:master Jul 14, 2020
@ntamas
Copy link
Member

ntamas commented Jul 14, 2020

Thanks a lot! The CI tests should now pass as I fixed the MSVC build error in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
todo Triaged for implementation in some unspecified future version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants