Handle pandas nullable integer data type in Graph.DataFrame #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for working the PR. I converted it to draft until it's ready for review. It looks reasonable. Can you please add a test for this? Maybe one case that uses this type and fails with a null value and one case that passes? Thank you |
|
@iosonofabio Done |
|
Let's see if it passes CI. If so I'll drag someone else for a final check and hopefully we can merge. Thank you! |
ntamas
approved these changes
Nov 9, 2022
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deal with #607.
Now the
Graph.DataFramecan take columns withInt64data type, and it throws an error when there is any null value.