Prefix param with underscore to prevent unused param warning #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mweststrate
requested changes
Sep 17, 2024
src/utils/common.ts
Outdated
| @@ -204,7 +204,7 @@ export function freeze<T>(obj: any, deep: boolean = false): T { | |||
| if (deep) | |||
| // See #590, don't recurse into non-enumerable / Symbol properties when freezing | |||
| // So use Object.entries (only string-like, enumerables) instead of each() | |||
| Object.entries(obj).forEach(([key, value]) => freeze(value, true)) | |||
| Object.entries(obj).forEach(([_key, value]) => freeze(value, true)) | |||
There was a problem hiding this comment.
Looks like this could be just Object.values which is probably faster and also skips the arg destructuring :)
Pull Request Test Coverage Report for Build 10910430741Details
💛 - Coveralls |
mweststrate
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the current issue:
Fixes #1144 by prefacing the unused param with
_.