Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix param with underscore to prevent unused param warning #1145

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Prefix param with underscore to prevent unused param warning #1145

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65c54a5
Prefix param with underscore to prevent unused param warning
alissalkvc Sep 12, 2024
25c35ca
Use Object.values since we don't need key
alissalkvc Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/utils/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ export function freeze<T>(obj: any, deep: boolean = false): T {
if (deep)
// See #590, don't recurse into non-enumerable / Symbol properties when freezing
// So use Object.entries (only string-like, enumerables) instead of each()
Object.entries(obj).forEach(([key, value]) => freeze(value, true))
Object.entries(obj).forEach(([_key, value]) => freeze(value, true))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this could be just Object.values which is probably faster and also skips the arg destructuring :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

return obj
}

Expand Down
Loading