Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on Node 18 #113

Closed
riovir opened this issue Apr 21, 2022 · 9 comments
Closed

Error on Node 18 #113

riovir opened this issue Apr 21, 2022 · 9 comments

Comments

@riovir
Copy link

riovir commented Apr 21, 2022

The address() function uses os.networkInterfaces(). A currently undocumented change in Node 18 resulted in the type of defails.family becoming a number.

Naturally, calling .toLowerCase() on the number throws an error.

@Apollon77
Copy link

Apollon77 commented Apr 25, 2022

see also nodejs/node#41431 (review)

@jaiswarvipin
Copy link

Found issue in the "ip.js" code where family variable value coming in value.

fix

On line 386 do following change

if(!isNaN(details.family)){
        details.family = ((details.family == 4)?"ipv4":"ipv6");
      }
      details.family = details.family.toLowerCase();

@Apollon77
Copy link

@jaiswarvipin The fix is easy ... The problem is that this library is used in many others, so it would need new versions of this lib with the fix to be really useful

@jaiswarvipin
Copy link

jaiswarvipin commented Apr 27, 2022

noted.

Currently not able to create / check-in as separate branch with new version, its giving access denied.

warning: ΓöîΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇ SECURITY WARNING ΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÉ
warning: Γöé TLS certificate verification has been disabled! Γöé
warning: ΓööΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÿ
warning: HTTPS connections may not be secure. See https://aka.ms/gcmcore-tlsverify for more information.
info: please complete authentication in your browser...
warning: ΓöîΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇ SECURITY WARNING ΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÉ
warning: Γöé TLS certificate verification has been disabled! Γöé
warning: ΓööΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÿ
warning: HTTPS connections may not be secure. See https://aka.ms/gcmcore-tlsverify for more information.
remote: Permission to indutny/node-ip.git denied to jaiswarvipin.
fatal: unable to access 'https://github.com/indutny/node-ip.git/': The requested URL returned error: 403

@jaiswarvipin
Copy link

Proposed fix for IPV4 and IPv6 (Single m/c/ Scale set, Kubernetes, Mobile Device) working as expected. Kindly merge the code base in main branch

@megaandros
Copy link

@sjoqvist
Copy link

sjoqvist commented May 3, 2022

@megaandros You're correct that it's a workaround, but I'd argue that downgrading to Node 17 isn't a proper fix to "Error on Node 18".

It should also be noted that Node 17 goes end-of-life on June 1, i.e. in just 29 days.

@indutny
Copy link
Owner

indutny commented May 10, 2022

This should be fixed in the latest release. Sorry it took me so long to get to it.

@indutny indutny closed this as completed May 10, 2022
@Apollon77
Copy link

Thank you very much(indeed ... the nodejs guys discuss reverting this breaking change btw ;-)))) ... but still anything ok with how you fixed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants