-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error on Node 18 #113
Comments
see also nodejs/node#41431 (review) |
Found issue in the "ip.js" code where family variable value coming in value. fix On line 386 do following change
|
@jaiswarvipin The fix is easy ... The problem is that this library is used in many others, so it would need new versions of this lib with the fix to be really useful |
noted. Currently not able to create / check-in as separate branch with new version, its giving access denied.
|
Proposed fix for IPV4 and IPv6 (Single m/c/ Scale set, Kubernetes, Mobile Device) working as expected. Kindly merge the code base in main branch |
The issue can be fixed with node.js = v.17.9.0 |
@megaandros You're correct that it's a workaround, but I'd argue that downgrading to Node 17 isn't a proper fix to "Error on Node 18". It should also be noted that Node 17 goes end-of-life on June 1, i.e. in just 29 days. |
This should be fixed in the latest release. Sorry it took me so long to get to it. |
Thank you very much(indeed ... the nodejs guys discuss reverting this breaking change btw ;-)))) ... but still anything ok with how you fixed it |
The
address()
function usesos.networkInterfaces()
. A currently undocumented change in Node 18 resulted in the type ofdefails.family
becoming a number.Naturally, calling
.toLowerCase()
on the number throws an error.The text was updated successfully, but these errors were encountered: