Dev server breaks with Node 18.0.0 + node-ip 1.1.5 #18019

riovir · 2022-04-21T11:05:07Z

Describe the bug
When updating to Node 18.0.0 start-storybook breaks with

TypeError: details.family.toLowerCase is not a function

	at .../node_modules/ip/lib/ip.js:385:39
	at .../node_modules/ip/lib/ip.js:384:37
	at .../node_modules/ip/lib/ip.js:379:37
	at .../node_modules/@storybook/core-server/dist/cjs/utils/server-address.js:20:55

To Reproduce
Launch a start-storybook with Node 18.0.0 and node-ip@1.1.5.

System

System:
OS: Windows 10 10.0.19044
CPU: (24) x64 12th Gen Intel(R) Core(TM) i9-12900KF
Binaries:
Node: 16.14.2 - C:\Program Files\nodejs\node.EXE
npm: 8.6.0 - C:\Program Files\nodejs\npm.CMD
Browsers:
Edge: Spartan (44.19041.1266.0), Chromium (100.0.1185.44)
npmPackages:
@storybook/addon-a11y: ^6.4.22 => 6.4.22
@storybook/addon-docs: ^6.4.18 => 6.4.22
@storybook/addon-essentials: ^6.4.22 => 6.4.22
@storybook/addons: ^6.4.18 => 6.4.22
@storybook/builder-webpack5: ^6.4.18 => 6.4.22
@storybook/manager-webpack5: ^6.4.18 => 6.4.22
@storybook/theming: ^6.4.18 => 6.4.22
@storybook/vue3: ^6.4.18 => 6.4.22

Additional context
This is caused by the following Node 18 introduced
Undocumented change to "family" attribute in os.networkInterfaces() in Node 18.
Issue on node-ip along with a PR has been submitted.

The text was updated successfully, but these errors were encountered:

riovir · 2022-04-21T15:40:30Z

Found a workaround.

The error only comes if Storybook attempts to figure out the current network address
If the host option is set then the problem is avoided.

So passing -h localhost to start-storybook bypasses the problem.

Cedric-ruiu · 2022-04-25T15:17:45Z

Same issue with Storybook 6.4 & Node 18.

kaelanbelaga · 2022-05-02T10:02:39Z

Found a workaround.

The error only comes if Storybook attempts to figure out the current network address If the host option is set then the problem is avoided.

So passing -h localhost to start-storybook bypasses the problem.

Thank you so much! That solved it for me.

sjoqvist · 2022-05-04T08:07:31Z

I'm running Storybook in Docker. The localhost workaround doesn't work for me. I can't connect to the server from my browser, even if the original error is muted. After digging around in the code, I could tell that --host is used for a few things. Apart for displaying a welcome message and opening Storybook in the browser, it's also passed to Express's listen().

With the information above, I got it to work with the unspecific IPv4 address 0.0.0.0, i.e. by passing --host 0.0.0.0 to start-storybook.

bonesoul · 2022-05-06T00:36:46Z

any landing fixes soon for this?

arayaryoma · 2022-05-10T05:39:22Z

I'm facing the same issue. Specifying --host localhost option caused a different error on my env.

My environment

macOS 12.3.1

npm: '8.8.0',
  node: '18.1.0',
  v8: '10.1.124.8-node.13',
  uv: '1.43.0',
  zlib: '1.2.11',
  brotli: '1.0.9',
  ares: '1.18.1',
  modules: '108',
  nghttp2: '1.47.0',
  napi: '8',
  llhttp: '6.0.4',
  openssl: '3.0.2+quic',
  cldr: '41.0',
  icu: '71.1',
  tz: '2022a',
  unicode: '14.0',
  ngtcp2: '0.1.0-DEV',
  nghttp3: '0.1.0-DEV'

"@storybook/addon-actions": "^6.4.22",
"@storybook/addon-docs": "^6.4.22",
"@storybook/addon-essentials": "^6.4.22",
"@storybook/addon-interactions": "^6.4.22",
"@storybook/addon-links": "^6.4.22",
"@storybook/addon-postcss": "^2.0.0",
"@storybook/builder-vite": "^0.1.32",
"@storybook/react": "^6.4.22"

.storybook/main.js

module.exports = {
    stories: ['../src/**/*.stories.mdx', '../src/**/*.stories.@(js|jsx|ts|tsx)'],
    addons: [
        '@storybook/addon-links',
        '@storybook/addon-essentials',
        '@storybook/addon-interactions',
    ],
    framework: '@storybook/react',
    core: {
        builder: '@storybook/builder-vite',
    },
};

Runned command

start-storybook -p 6006 --host localhost

Result

node:internal/crypto/hash:67
  this[kHandle] = new _Hash(algorithm, xofLen);
                  ^

Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:67:19)
    at Object.createHash (node:crypto:133:10)
    at module.exports (__PATH__/node_modules/@storybook/manager-webpack4/node_modules/webpack/lib/util/createHash.js:135:53)
    at NormalModule._initBuildHash (__PATH__/node_modules/@storybook/manager-webpack4/node_modules/webpack/lib/NormalModule.js:417:16)
    at handleParseError (__PATH__/node_modules/@storybook/manager-webpack4/node_modules/webpack/lib/NormalModule.js:471:10)
    at __PATH__/node_modules/@storybook/manager-webpack4/node_modules/webpack/lib/NormalModule.js:503:5
    at __PATH__/node_modules/@storybook/manager-webpack4/node_modules/webpack/lib/NormalModule.js:358:12
    at __PATH__/node_modules/@storybook/manager-webpack4/node_modules/loader-runner/lib/LoaderRunner.js:373:3
    at iterateNormalLoaders (__PATH__/node_modules/@storybook/manager-webpack4/node_modules/loader-runner/lib/LoaderRunner.js:214:10)
    at Array.<anonymous> (__PATH__/node_modules/@storybook/manager-webpack4/node_modules/loader-runner/lib/LoaderRunner.js:205:4)
    at Storage.finished (__PATH__/node_modules/@storybook/manager-webpack4/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:55:16)
    at __PATH__/node_modules/@storybook/manager-webpack4/node_modules/enhanced-resolve/lib/CachedInputFileSystem.js:91:9
    at __PATH__/node_modules/graceful-fs/graceful-fs.js:123:16
    at FSReqCallback.readFileAfterClose [as oncomplete] (node:internal/fs/read_file_context:68:3) {
  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}

bodograumann · 2022-05-10T06:31:27Z

@arayaryoma Please see #16555 for this issue.

riovir · 2022-05-10T11:35:58Z

Meanwhile, node-ip@1.1.6 and node-ip2.0.0 have been released already including the fix. Fixing this issue should be a version bump now. (Fingers crossed.)

See: storybookjs/storybook#18019 Should we resolved in `ip` version 1.1.6 or 2.0.0, see: indutny/node-ip@4de50ae

See: storybookjs/storybook#18019 Should we resolved in `ip` version 1.1.6 or 2.0.0, see: indutny/node-ip@4de50ae adeira-source-id: 323b79bd85f45b13c82badc12790fb1030aa84d4

bonesoul · 2022-05-11T12:32:55Z

any news on this?

sjoqvist · 2022-05-11T19:18:16Z

any news on this?

@bonesoul This is fixed in node-ip@1.1.6, so it should be enough to upgrade your dependencies. I chose to enforce a package resolution using Yarn and leave all other packages as they were. YMMV.

rpehlivan1 · 2022-05-13T21:25:33Z

As a workaround, what helped me to make storybook work with node 18, is install these addons and webpack

 "@storybook/builder-webpack5": "^6.4.22",
 "@storybook/manager-webpack5": "^6.4.22",
  "webpack": "^5.0.0"

main.js

module.exports = {
  core: {
    builder: 'webpack5',
  },
}

shilman · 2022-05-27T18:30:28Z

Great Caesar's ghost!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.5.6-alpha.0 containing PR #18330 that references this issue. Upgrade today to the @prerelease NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

…rybook#18019

shilman · 2022-05-30T00:12:55Z

Good golly!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.5.6 containing PR #18330 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb upgrade

thclark · 2022-06-15T10:25:32Z

including the fix

can confirm that updating node-ip to ^1.1.8 does fix the issue so if you can't upgrade your storybook for some reason, then you can add:

  "dependencies": {
    "ip": "^1.1.8",
  },
  "resolutions": {
    "ip": "^1.1.8"
  },

to your package.json and you're good to go until you can update storybook.

eric-burel · 2022-11-08T09:49:06Z

Edit: actually my issue is tracked at #16555

I seem to have this issue with following dependencies:

    "@babel/core": "^7.19.3",
    "@rollup/plugin-commonjs": "^22.0.2",
    "@rollup/plugin-node-resolve": "^14.1.0",
    "@storybook/addon-a11y": "^6.5.12",
    "@storybook/addon-actions": "^6.5.12",
    "@storybook/addon-essentials": "^6.5.12",
    "@storybook/addon-interactions": "^6.5.12",
    "@storybook/addon-links": "^6.5.12",
    "@storybook/builder-webpack4": "^6.5.12",
    "@storybook/manager-webpack4": "^6.5.12",
    "@storybook/test-runner": "^0.7.2",
    "@storybook/testing-library": "^0.0.13",
    "@storybook/web-components": "^6.5.12",
    "autoprefixer": "^10.4.12",
    "babel-loader": "^8.2.5",
    "eslint": "^8.24.0",
    "eslint-plugin-lit": "^1.6.1",
    "lit-html": "^2.3.1"

I can't run sb upgrade yet (we use 2 separate package.json to isolate the dependencies of Storybook from the code), is there something else to do to avoid this issue?

"ip" is on 1.1.8 as expected

I am on 6.5.12 and it seemed to have been fixed in 6.5.6 already.

I am using Node 18.12.0.

The error message is specifically the one from @arayaryoma above, related to "crypto": #18019 (comment)

fatikh1808 · 2023-09-19T20:01:24Z

export NODE_OPTIONS=--openssl-legacy-provider

solved the issue for me

https://stackoverflow.com/questions/69692842/error-message-error0308010cdigital-envelope-routinesunsupported

riovir added bug needs triage labels Apr 21, 2022

sjoqvist mentioned this issue Apr 30, 2022

Add support for React 18 #17831

Closed

shilman added has workaround dependencies and removed needs triage labels May 3, 2022

shadab-skhan mentioned this issue May 6, 2022

Enforce minimum npm and node version equinor/webviz-subsurface-components#971

Merged

mrtnzlml added a commit to adeira/universe that referenced this issue May 10, 2022

SX Design: patch 3rd party dependency

0d36820

See: storybookjs/storybook#18019 Should we resolved in `ip` version 1.1.6 or 2.0.0, see: indutny/node-ip@4de50ae

mrtnzlml mentioned this issue May 10, 2022

SX Design: patch 3rd party dependency adeira/universe#4391

Merged

kodiakhq bot pushed a commit to adeira/universe that referenced this issue May 10, 2022

SX Design: patch 3rd party dependency

323b79b

See: storybookjs/storybook#18019 Should we resolved in `ip` version 1.1.6 or 2.0.0, see: indutny/node-ip@4de50ae

mrtnzlml mentioned this issue May 13, 2022

SX Design: test Storybook via Playwright adeira/universe#4392

Merged

yamish123 mentioned this issue May 17, 2022

chore: update dependency cimg/node to v18 kufu/smarthr-ui#2465

Merged

1 task

yannbf mentioned this issue May 25, 2022

Core: Fix node 18 ip support #18330

Merged

3 tasks

shilman closed this as completed May 27, 2022

2p4b pushed a commit to 2p4b/octal-clients that referenced this issue May 28, 2022

update storybook packjson specify host --host 0.0.0.0 storybookjs/sto…

0372d39

…rybook#18019

NicolasRuleev mentioned this issue Aug 24, 2022

Storybook does not work jerriclynsjohn/svelte-storybook-tailwind#22

Closed

takurinton mentioned this issue Sep 29, 2022

Update Node.js version of CI runtime and storybook voyagegroup/ingred-ui#1007

Merged

thescientist13 mentioned this issue Dec 17, 2022

upgrade greenwood and GitHub Actions for node 18 AnalogStudiosRI/www.tuesdaystunes.tv#110

Merged

2 tasks

rajsite mentioned this issue Feb 1, 2023

Nimble does not build with node 18 LTS ni/nimble#799

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev server breaks with Node 18.0.0 + node-ip 1.1.5 #18019

Dev server breaks with Node 18.0.0 + node-ip 1.1.5 #18019

riovir commented Apr 21, 2022

riovir commented Apr 21, 2022 •

edited

Loading

Cedric-ruiu commented Apr 25, 2022

kaelanbelaga commented May 2, 2022

sjoqvist commented May 4, 2022

bonesoul commented May 6, 2022

arayaryoma commented May 10, 2022 •

edited

Loading

bodograumann commented May 10, 2022

riovir commented May 10, 2022

bonesoul commented May 11, 2022

sjoqvist commented May 11, 2022

rpehlivan1 commented May 13, 2022

shilman commented May 27, 2022

shilman commented May 30, 2022

thclark commented Jun 15, 2022

eric-burel commented Nov 8, 2022 •

edited

Loading

fatikh1808 commented Sep 19, 2023

Dev server breaks with Node 18.0.0 + node-ip 1.1.5 #18019

Dev server breaks with Node 18.0.0 + node-ip 1.1.5 #18019

Comments

riovir commented Apr 21, 2022

riovir commented Apr 21, 2022 • edited Loading

Cedric-ruiu commented Apr 25, 2022

kaelanbelaga commented May 2, 2022

sjoqvist commented May 4, 2022

bonesoul commented May 6, 2022

arayaryoma commented May 10, 2022 • edited Loading

My environment

.storybook/main.js

Runned command

Result

bodograumann commented May 10, 2022

riovir commented May 10, 2022

bonesoul commented May 11, 2022

sjoqvist commented May 11, 2022

rpehlivan1 commented May 13, 2022

shilman commented May 27, 2022

shilman commented May 30, 2022

thclark commented Jun 15, 2022

eric-burel commented Nov 8, 2022 • edited Loading

fatikh1808 commented Sep 19, 2023

riovir commented Apr 21, 2022 •

edited

Loading

arayaryoma commented May 10, 2022 •

edited

Loading

eric-burel commented Nov 8, 2022 •

edited

Loading