Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPv6 hosts are not supported #623

Closed
tedpearson opened this issue Sep 1, 2023 · 1 comment · Fixed by #706
Closed

IPv6 hosts are not supported #623

tedpearson opened this issue Sep 1, 2023 · 1 comment · Fixed by #706
Assignees
@karel-rehor
Milestone
7.1.0

Comments

@tedpearson
Copy link

tedpearson commented Sep 1, 2023 •
edited
Loading

influxdb-client-java/client/src/main/java/com/influxdb/client/InfluxDBClientOptions.java

Line 697 in 886eb88

String urlWithoutParams = url.scheme() + "://" + url.host() + ":" + url.port() + url.encodedPath();

The InfluxDBClientOptions.ParsedUrl constructor strips the square brackets off IPv6 addresses, rendering urls containing them invalid. E.g. http://[2001:db8:3333:4444:5555:6666:7777:8888]:8086/ becomes http://2001:db8:3333:4444:5555:6666:7777:8888:8086/.

See how okhttp3 HttpUrl.Builder.toString() handles IPv6 addresses.
@bednar
Copy link
Contributor

bednar commented Sep 5, 2023

Hi @tedpearson,

thanks for using our client.

Is this something you would be willing to help with? All PR is welcome and we will be happy to review your submission.

Regards

karel-rehor added a commit that referenced this issue Apr 24, 2024
@karel-rehor
fix: issue #623 - support IPv6 hosts
7d51d96
@karel-rehor karel-rehor mentioned this issue Apr 25, 2024
Merged
6 tasks
karel-rehor added a commit that referenced this issue Apr 26, 2024
@karel-rehor
fix: Issue/623 (#706)
cf762ae 
* fix: issue #623 - support IPv6 hosts

* chore: troubleshoot Protocol family unavailable in CircleCI

* chore: troubleshoot ipv6 enable

* chore: troubleshoot of troubleshoot ipv6 enable

* chore: specify latest circleci ubuntu image

* chore: troubleshoot where to place image definition

* chore: investigate ulimit error cause in docker

* chore: inspect docker/daemon.json

* chore: retry inspection

* chore: troubleshoot docker restart

* chore: inspect service commands

* chore: check docker service status

* chore: check service status in circleci

* chore: explicit start docker service

* chore: troubleshoot tests

* chore: try different location for machine

* chore: remove machine block

* chore: restore config.yml to master verstion

* test: removes IPv6 dependent test - not supported by default docker in Circleci

* docs: update CHANGELOG.md
@bednar bednar added this to the 7.1.0 milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karel-rehor karel-rehor

Labels
None yet
Projects
None yet
Milestone
7.1.0
Development

Successfully merging a pull request may close this issue.

fix: Issue/623 influxdata/influxdb-client-java
3 participants
@bednar @tedpearson @karel-rehor