Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issue/623 #706

Merged
merged 20 commits into from
Apr 26, 2024
Merged

fix: Issue/623 #706

merged 20 commits into from
Apr 26, 2024

Conversation

karel-rehor
Copy link
Contributor

@karel-rehor karel-rehor commented Apr 25, 2024

Closes #623

Proposed Changes

Change the way in which InfluxDBClientOptions prepares a parsed URL, so that IPv6 addresses will be detected and preserved.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@karel-rehor karel-rehor requested a review from bednar April 25, 2024 07:52
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! 👍

LGTM 🚀

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.37%. Comparing base (1b10317) to head (1605677).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #706      +/-   ##
============================================
+ Coverage     88.33%   88.37%   +0.04%     
- Complexity      771      784      +13     
============================================
  Files           174      174              
  Lines          7088     7089       +1     
  Branches        389      390       +1     
============================================
+ Hits           6261     6265       +4     
+ Misses          700      698       -2     
+ Partials        127      126       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karel-rehor karel-rehor marked this pull request as ready for review April 25, 2024 14:19
@karel-rehor karel-rehor merged commit cf762ae into master Apr 26, 2024
11 checks passed
@karel-rehor karel-rehor deleted the issue/623 branch April 26, 2024 11:32
@bednar bednar added this to the 7.1.0 milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPv6 hosts are not supported
3 participants