-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inputs.sqlserver): fixing wrong filtering for sqlAzureMIRequests and sqlAzureDBRequests #11701
Conversation
@Trovalo thoughts? |
I'll have a look at it soon |
4f9a7ba
to
9b570ec
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you both for the PR and the review!
PR #10553 for an issue #10741 introduced a wrong filtering which leads to the state that all sessions are shown in the output - disregarding if they are running requests or not.
The filtering condition:
[request_id] IS NOT NULL --A request must exists
couldn't be ever true as in the previous code the [request_id] has been already changed to NonNullable inside the inner query:
NULLIF(r.[blocking_session_id],0) AS [blocking_session_id]