Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.sqlserver): improved filtering for active requests #11709

Merged
merged 3 commits into from
Sep 7, 2022

Conversation

deweter
Copy link
Contributor

@deweter deweter commented Aug 22, 2022

The output from sys.dm_exec_requests contains a static request from telegraf which has no added value and only makes the output larger and harder to read. The only situation, when this should be shown is when it becomes a heading blocker. This unlikely possibility is taken into account in a code. Similar filter is used by other monitoring tools and is included in Glenn Berry's diagnostic queries solution

This is a sample ouput before this feat on idle system. It contains a telegraf request to gain the requests:
image

This is a sample output after this change on idle system:
image

@deweter deweter changed the title Feat/inputs.sqlserver/requests Feat(inputs.sqlserver): Improved filtering for active requests Aug 22, 2022
@deweter deweter changed the title Feat(inputs.sqlserver): Improved filtering for active requests feat(inputs.sqlserver): improved filtering for active requests Aug 22, 2022
@telegraf-tiger
Copy link
Contributor

@deweter
Copy link
Contributor Author

deweter commented Sep 2, 2022

Please, can someone make a review? @powersj @MyaLongmire

@MyaLongmire
Copy link
Contributor

@deweter Thanks for the pr, sorry we haven't gotten back to you yet.

The code looks okay to me but does this break backward compatibility for some users?

@deweter
Copy link
Contributor Author

deweter commented Sep 2, 2022

I don't think so as the output from this query was completely wrong for several months and we fixed it recently in PR #11701.

@MyaLongmire MyaLongmire added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 2, 2022
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the contribution @deweter and sorry for the late response!

@srebhan srebhan self-assigned this Sep 7, 2022
@srebhan srebhan merged commit ab18588 into influxdata:master Sep 7, 2022
dba-leshop pushed a commit to dba-leshop/telegraf that referenced this pull request Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants