-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.sqlserver): improved filtering for active requests #11709
feat(inputs.sqlserver): improved filtering for active requests #11709
Conversation
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Please, can someone make a review? @powersj @MyaLongmire |
@deweter Thanks for the pr, sorry we haven't gotten back to you yet. The code looks okay to me but does this break backward compatibility for some users? |
I don't think so as the output from this query was completely wrong for several months and we fixed it recently in PR #11701. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for the contribution @deweter and sorry for the late response!
The output from sys.dm_exec_requests contains a static request from telegraf which has no added value and only makes the output larger and harder to read. The only situation, when this should be shown is when it becomes a heading blocker. This unlikely possibility is taken into account in a code. Similar filter is used by other monitoring tools and is included in Glenn Berry's diagnostic queries solution
This is a sample ouput before this feat on idle system. It contains a telegraf request to gain the requests:
This is a sample output after this change on idle system: