Use send_tx directly in ChainDriver for integration test
#2205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce TxConfig Add test constructor for TxConfig Add send_tx method on ChainDriver Accept Wallet instead of WalletAddress for transferring tokens Implement ibc_token_transfer Simplify ibc_token_transfer Token transfer using ibc_token_transfer is now working
soareschen
requested review from
adizere,
romac,
seanchen1991 and
ancazamfir
as code owners
soareschen
commented
May 11, 2022
| { | ||
| info!("sending first IBC transfer after client is expired. this should cause packet worker to fail"); | ||
|
|
||
| chains.node_a.chain_driver().transfer_token( |
There was a problem hiding this comment.
The tests here has to be removed, because since Gaia v7 the transaction will fail. Apparently we didn't catch this error previously, because submitting the transaction via the gaiad command do not result in error.
romac
approved these changes
May 11, 2022
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
…lsystems#2205) * Add simple_send_tx Introduce TxConfig Add test constructor for TxConfig Add send_tx method on ChainDriver Accept Wallet instead of WalletAddress for transferring tokens Implement ibc_token_transfer Simplify ibc_token_transfer Token transfer using ibc_token_transfer is now working * Move AddressType into TxConfig, as it is configured per chain * Disable GRPC Web and not rely on chain version * Clean up ibc_transfer_token interface on ChainDriver * Use longer IBC transfer timeout * Further increase IBC transfer timeout * Fix client expiration test in gaia7 * Move tx_raw_ft_transfer to simulation test * Modularize ibc_token_transfer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2012
Prerequisite for: #1981
Description
This is a follow up on #2044 to use
send_txdirectly inChainDriverfor integration test. This allows us to write tests that send arbitrary transactions with any wallet inside the integration test.Prior to this, we have the limitation that transactions have to be submitted via the
gaiadcommand, with quirks like #2012. Otherwise theChainHandledesign has the limitation of having a global wallet that is tied to the relayer, which makes it very tricky to submit transactions using multiple non-relayer wallets.This is required for #1981 so that we can send atomic transaction that include
MsgPayPacketFee, as well as submittingMsgPayPacketFeeAsyncusing the user wallet. Without this, it will be problematic to do this viagaiad, and it is unclear whether thegaiadCLI currently supports IBC transfer with packet fee. This PR makes it straightforward for us to submit such transactions directly, as long as there is a protobuf definition that can convert the domain type intoprost::Any.PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.