ICS29 Fee Middleware Support #1981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce TxConfig Add test constructor for TxConfig Add send_tx method on ChainDriver Accept Wallet instead of WalletAddress for transferring tokens Implement ibc_token_transfer Simplify ibc_token_transfer Token transfer using ibc_token_transfer is now working
6 tasks
soareschen
force-pushed
the
soares/ics29-fee-middleware
branch
from
655aca9 to
9bbc35a
Compare
soareschen
force-pushed
the
soares/ics29-fee-middleware
branch
from
099d9fa to
bb15577
Compare
Set minimum price on node bootstrap
ljoss17
reviewed
Oct 13, 2022
ljoss17
reviewed
Oct 13, 2022
|
@ljoss17 I just found a detailed tutorial by the IBC-go team on fee-enabled ft-transfers. Hope it proves useful in reviewing or understanding ICS29! https://github.com/cosmos/ibc-go/wiki/Fee-enabled-fungible-token-transfers |
Awesome, thank you! I'll try it out! |
…the ICS29 feature
ljoss17
approved these changes
Oct 17, 2022
There was a problem hiding this comment.
Except for the two small suggestions, everything seems great.
The Fee Middleware was successfully tested the two following ways:
Using test_setup_with_fee_enabled_binary_channel.rs
Same method as the one used in this PR: #2682
Using chains spawned with simd binary
Inspired by this tutorial: https://github.com/cosmos/ibc-go/wiki/Fee-enabled-fungible-token-transfers
- In the section https://github.com/cosmos/ibc-go/wiki/Fee-enabled-fungible-token-transfers#setup use this forked repository, which has been updated in order to run with Hermes
v1.0.0: https://github.com/ljoss17/simd-scripts - If required, in the file
network/hermes/variables.shcorrectly configureHERMES_BINARYto point to the Hermes binary which has the ICS29 Fee Middleware Support - In the section https://github.com/cosmos/ibc-go/wiki/Fee-enabled-fungible-token-transfers#create-a-fee-enabled-ics20-fungible-token-transfer-channel instead of the command:
hermes -c ./network/hermes/config.toml create channel test-1 connection-0 \ --port-a transfer \ --port-b transfer \ -v "{\"fee_version\":\"ics29-1\",\"app_version\":\"ics20-1\"}", use the command:hermes --config ./network/hermes/config.toml create channel --a-chain test-1 --a-connection connection-0 --a-port transfer --b-port transfer --channel-version "{\"fee_version\":\"ics29-1\",\"app_version\":\"ics20-1\"}" - In the section https://github.com/cosmos/ibc-go/wiki/Fee-enabled-fungible-token-transfers#register-the-counterparty-payee, instead of using
simd tx ibc-fee register-counterparty-payeeto register the counterparty-payee, use hermes command to do it:hermes --config network/hermes/config.toml fee register-counterparty-payee --chain test-2 --channel channel-0 --port transfer --counterparty-payee $RLY_1 - For all transfers, instead of using
simd tx ibc-transfer transfer transfer, use hermes transfer command, e.g.hermes --config network/hermes/config.toml fee transfer --dst-chain test-2 --src-chain test-1 --src-port transfer --src-channel channel-0 --amount 1000 --denom stake --receive-fee 50 --ack-fee 25 --timeout-fee 10 --key-name wallet1 --recipient $WALLET_3 --timeout-seconds 120
If we compare the balance of $RLY_1, $RLY_2, $WALLET_1 and $WALLET_2 before and after the transfer, the following should be true:
- For the forward relayer
$RLY_1, the final balance is:initial_balance - gas_fee + recv_fee (50) + ack_fee (25) - For the reverse relayer
$RLY_2, the final balance is:initial_balance - gas_fee - For
$WALLET_1the balance is:initial_balance - transfer_amount (1000) - recv_fee (50) - ack_fee(25) - gas_fee - For
$WALLET_2the balance is the same for stake but has an additional1000 ibc/<hash>
The gas fees can be retrieved by the logs in the terminal which called hermes start
tools/integration-test/src/bin/test_setup_with_fee_enabled_binary_channel.rs
Outdated
Show resolved
Hide resolved
tools/integration-test/src/bin/test_setup_with_fee_enabled_binary_channel.rs
Outdated
Show resolved
Hide resolved
tools/integration-test/src/bin/test_setup_with_fee_enabled_binary_channel.rs
Outdated
Show resolved
Hide resolved
Signed-off-by: Sean Chen <skypemaster007@gmail.com>
Signed-off-by: Sean Chen <skypemaster007@gmail.com>
…ary_channel.rs Signed-off-by: Sean Chen <skypemaster007@gmail.com>
…ary_channel.rs Signed-off-by: Sean Chen <skypemaster007@gmail.com>
Signed-off-by: Sean Chen <skypemaster007@gmail.com>
Signed-off-by: Sean Chen <skypemaster007@gmail.com>
Signed-off-by: Sean Chen <skypemaster007@gmail.com>
…ary_channel.rs Signed-off-by: Sean Chen <skypemaster007@gmail.com>
Co-authored-by: Luca Joss <43531661+ljoss17@users.noreply.github.com> Signed-off-by: Romain Ruetschi <romain.ruetschi@gmail.com>
romac
approved these changes
Oct 24, 2022
This was referenced Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a work in progress to support ICS29 fee middleware. This branch tracks the changes made in cosmos/ibc-go#276, which is not yet merged.
Tasks:
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.