Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lit to v2 #1489

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Update Lit to v2 #1489

merged 2 commits into from
Nov 11, 2021

Conversation

abdonrd
Copy link
Contributor

@abdonrd abdonrd commented Aug 21, 2021

What I did

  1. Update Lit to v2.0.0

@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2021

🦋 Changeset detected

Latest commit: c4562f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@lion/core Minor
@lion/button Patch
@lion/combobox Patch
@lion/dialog Patch
@lion/form Patch
@lion/form-core Patch
@lion/form-integrations Patch
@lion/input Patch
@lion/listbox Patch
@lion/localize Patch
@lion/overlays Patch
@lion/select-rich Patch
@lion/tooltip Patch
providence-analytics Patch
@lion/accordion Patch
@lion/calendar Patch
@lion/checkbox-group Patch
@lion/collapsible Patch
@lion/fieldset Patch
@lion/helpers Patch
@lion/icon Patch
@lion/input-amount Patch
@lion/input-date Patch
@lion/input-datepicker Patch
@lion/input-email Patch
@lion/input-iban Patch
@lion/input-range Patch
@lion/input-stepper Patch
@lion/pagination Patch
@lion/progress-indicator Patch
@lion/radio-group Patch
@lion/select Patch
@lion/steps Patch
@lion/switch Patch
@lion/tabs Patch
@lion/textarea Patch
@lion/validate-messages Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tlouisse
Copy link
Member

Awesome @abdonrd 👍 Would you like to add a changeset please as well? (npm run changeset and then a patch bump (assuming there's nothing breaking of course))

@tlouisse
Copy link
Member

tlouisse commented Aug 24, 2021

Hmm, build fails atm... You can set this limit to 13 for now: https://github.com/ing-bank/lion/blob/master/package.json#L105

Could you also squash all commits into one?

@abdonrd
Copy link
Contributor Author

abdonrd commented Aug 24, 2021

Hmm, build fails atm... You can set this limit to 13 for now: https://github.com/ing-bank/lion/blob/master/package.json#L105
Done!

Could you also squash all commits into one?

Could you do it with the GitHub merge button?

Screenshot 2021-08-24 at 13 13 52

If not, I can do it locally.

@tlouisse
Copy link
Member

Could you do it with the GitHub merge button?

Yes, possible as well of course :)

Still two problems:

The latter is something we most likely need to look at I think (although contributions are always welcome of course).
Hopefully we will find some time for this soon.

@abdonrd
Copy link
Contributor Author

abdonrd commented Aug 25, 2021

@tlouisse updated, squashed and rebased!

@tlouisse
Copy link
Member

tlouisse commented Aug 27, 2021

Hmm, seems there's a problem with the built version of lit:
Screenshot 2021-08-27 at 16 42 51

This causes 103 of our 2174 tests to fail...

When I run our docs with the development version of lit, no errors seem to occur. (after adding this to rocket.config.mjs):

  devServer: {
    nodeResolve: {
      exportConditions: ['development'],
    },
  },

@tlouisse
Copy link
Member

tlouisse commented Sep 14, 2021

Updated to v2.0.0-rc.4. Same errors still :(

So when I run tests with default (minified) lit: 103 errors. Something is off with the terse step? (or are we using a private api we weren't allowed to that is renamed in this step?)

When tests are run with development mode (unminified) lit: only 3 errors.

@abdonrd abdonrd changed the title Update Lit to v2.0.0-rc.3 Update Lit to v2 Oct 1, 2021
@abdonrd
Copy link
Contributor Author

abdonrd commented Oct 4, 2021

Probably related: lit/lit.dev#535

@gerjanvangeest gerjanvangeest force-pushed the lit-update branch 2 times, most recently from ae06a54 to 8cd0f44 Compare November 11, 2021 07:57
@gerjanvangeest
Copy link
Member

@abdonrd Thanks for all the updates, helps us a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants