-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Lit to v2 #1489
Update Lit to v2 #1489
Conversation
🦋 Changeset detectedLatest commit: c4562f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Awesome @abdonrd 👍 Would you like to add a changeset please as well? ( |
Hmm, build fails atm... You can set this limit to 13 for now: https://github.com/ing-bank/lion/blob/master/package.json#L105 Could you also squash all commits into one? |
Could you do it with the GitHub merge button? If not, I can do it locally. |
Yes, possible as well of course :) Still two problems:
The latter is something we most likely need to look at I think (although contributions are always welcome of course). |
@tlouisse updated, squashed and rebased! |
Updated to v2.0.0-rc.4. Same errors still :( So when I run tests with default (minified) lit: 103 errors. Something is off with the terse step? (or are we using a private api we weren't allowed to that is renamed in this step?) When tests are run with development mode (unminified) lit: only 3 errors. |
Probably related: lit/lit.dev#535 |
f69aec6
to
93b7ad4
Compare
ae06a54
to
8cd0f44
Compare
@abdonrd Thanks for all the updates, helps us a lot :) |
8cd0f44
to
ae83c66
Compare
ae83c66
to
c4562f7
Compare
What I did