This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
CDEC-494: Part two of block consolidation #3491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikd
force-pushed
the
erikd/CDEC-494-2
branch
2 times, most recently
from
3c7d1ec
to
7189a4f
Compare
ruhatch
approved these changes
Aug 28, 2018
|
|
||
| -- This type is a pain in the neck, but we have to live with it forever | ||
| -- because this encoding is baked into the system. The best we can do is | ||
| -- provide helper functions to minimise the pain. |
There was a problem hiding this comment.
Can you explain the problems with using the type a bit further (here rather than in the code). How is it baked into the system? Couldn't we have an alternative in Haskell-land that is encoded the same way in the blocks?
db/src/Pos/DB/Block/Epoch.hs
Outdated
| -- Consolidate from the check point until the specified 'endEpoch'. If | ||
| -- the 'endEpoch' has already been consolidated, return success. | ||
| -- On each loop, the check point in the 'MiscDB' is updated. | ||
| consoldateLoop |
There was a problem hiding this comment.
Should be consolidateLoop!
| lift $ mapM_ deleteOldBlund sihs | ||
|
|
||
| when (ccpEpochIndex nextCcp < endEpoch) $ | ||
| loop nextCcp |
erikd
force-pushed
the
erikd/CDEC-494-2
branch
from
7189a4f
to
813f400
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is probably not documented as well as it could be. Please point out things that you think need documenting.
This PR adds new code, but does not drastically change the operation of the code, but adds a shim layer to the old block storage so that when consolidation is activated, blocks can be retrieved from either the consolidated epoch/index files (if they have been consolidated) or the blund files if they have not.
The consolidation code is really difficult to test because it needs a huge about or environment that is really difficult to set up. I do have a separate program to test consolidation and it does work, and it is possible to retrieve blunds/block/undos that have been consolidated.
Linked issue
https://iohk.myjetbrains.com/youtrack/issue/CDEC-494
Type of change
Developer checklist
Testing checklist
QA Steps
With the code in this PR:
cardano-nodecould sync to mainnet from the original genesis block.Screenshots (if available)