Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

Fix bad Github merge #3500

Merged
merged 1 commit into from
Aug 29, 2018
Merged

Fix bad Github merge #3500

merged 1 commit into from
Aug 29, 2018

Conversation

erikd
Copy link
Member

@erikd erikd commented Aug 29, 2018

Description

The changes in PRs #3491 and #3482 turned out to be incompatible.
To avoind things like this, it would be ideal if PRs were not merged unless they were rebased and had a complete CI build first.

Linked issue

N/A

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

The changes in PRs #3491 and #3482 turned out to be incompatible.
To avoind things like this, it would be ideal if PRs were not
merged unless they were rebased and had a complete CI build first.
@erikd erikd force-pushed the topic/fix-bad-github-merge branch from ff279b8 to 0092424 Compare August 29, 2018 05:36
Copy link
Contributor

@edsko edsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@CodiePP
Copy link
Contributor

CodiePP commented Aug 29, 2018

fine with me. I think it is hard to avoid such coincidences.
Now, it just turned green!

@CodiePP CodiePP merged commit 7944c1b into develop Aug 29, 2018
@adinapoli-iohk adinapoli-iohk deleted the topic/fix-bad-github-merge branch August 29, 2018 06:34
@erikd
Copy link
Member Author

erikd commented Aug 29, 2018

I think it is hard to avoid such coincidences.

At my previous employer we had a CI test that only turned green if the PR branch had been rebased against the branch it was being merged to.

@CodiePP
Copy link
Contributor

CodiePP commented Aug 29, 2018

good point; you should propose it to devops. I am PRO!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants