Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[CBR-97] allow building 'post-mortem' tool from nix #3640

Closed
wants to merge 3 commits into from

Conversation

CodiePP
Copy link
Contributor

@CodiePP CodiePP commented Sep 20, 2018

Description

In benchmarking we depend on the tool 'post-mortem' for analysis of results.
Unfortunately, this executable cannot be built with nix, since we cannot pass the required flag to nix-build.
Therefore, we propose to remove this flag from tool's cabal file.

Linked issue

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • [~] I have read the style guide document, and my code follows the code style of this project.
  • [~] If my code deals with exceptions, it follows the guidelines.
  • [~] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • [~] CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • [~] I have added tests to cover my changes.
  • [~] All new and existing tests passed.

QA Steps

nix-build -A cardano-sl-tools -o post-mortem

CodiePP and others added 3 commits September 26, 2018 13:43
Signed-off-by: Alexander Diemand <codieplusplus@apax.net>
Signed-off-by: Alexander Diemand <codieplusplus@apax.net>
@CodiePP CodiePP force-pushed the benchmarking/nix_buildable_post-mortem branch from a3c7ef1 to 090fc90 Compare September 26, 2018 11:44
@CodiePP
Copy link
Contributor Author

CodiePP commented Sep 27, 2018

post-mortem tool has been moved to its own space in PR #3670
this one can then be closed.

@CodiePP CodiePP closed this Sep 27, 2018
@CodiePP CodiePP deleted the benchmarking/nix_buildable_post-mortem branch October 26, 2018 08:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants