Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

[PB-95] independent 'post-mortem' tool #3670

Merged
merged 3 commits into from
Sep 28, 2018

Conversation

CodiePP
Copy link
Contributor

@CodiePP CodiePP commented Sep 27, 2018

Description

we cannot build post-mortem tool in the benchmark environment on staging, because its compilation is protected by a flag (cannot be passed via 'nix-build').
therefore, the tool has been moved to its own location under control of its own cabal file.

Linked issue

PB-94 (user story)
PB-95 (task)

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • [~] I have read the style guide document, and my code follows the code style of this project.
  • [~] If my code deals with exceptions, it follows the guidelines.
  • [~] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • [~] CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • [~] I have added tests to cover my changes.
  • [~] All new and existing tests passed.

QA Steps

nix-build -A cardano-sl-tools-post-mortem -o post-mortem

@CodiePP CodiePP added the wip label Sep 27, 2018
@CodiePP CodiePP force-pushed the benchmarking/PB-94/independent_post-mortem branch 2 times, most recently from 17e74c9 to df3d0a9 Compare September 27, 2018 10:18
@CodiePP CodiePP removed the wip label Sep 27, 2018
@CodiePP
Copy link
Contributor Author

CodiePP commented Sep 27, 2018

building with nix-build -A cardano-sl-tools-post-mortem -o post-mortem works perfectly.

@CodiePP CodiePP force-pushed the benchmarking/PB-94/independent_post-mortem branch from dac98a8 to 295afb8 Compare September 28, 2018 05:35
@CodiePP
Copy link
Contributor Author

CodiePP commented Sep 28, 2018

rebased on develop

@CodiePP CodiePP merged commit e91da48 into develop Sep 28, 2018
@CodiePP CodiePP deleted the benchmarking/PB-94/independent_post-mortem branch September 28, 2018 06:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants