Support constraining reference types #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses part of #36 - comments are still not supported _everywhere_, but they are allowed on group entries, which represent the area (other than top-level rules) where comments are the most useful. The same "comment" syntax is used as with top-level rules. Note that this does not (yet) work within groups - that will be addressed as part of #32. As yet, the parser still does not deal with comments, or attribute them to any entity. The tests are likewise oblivious to comments. But this does allow Huddle to define comments and have them reflected in the generated CDDL, which was the principal outcome.
Before this commit, it wasn't possible to apply constraints (e.g. '.size') to references, only directly to Value types. This gives us some nice type safety (you can't apply '.cbor' to an integer, for example), it also doesn't allow us to constrain types which are passed as generic parameters, or where we genuinely want to constrain another rule. This commit changes that by allowing references (both direct and generic) to be constrained. Obviously we don't have any guarantees here that what we are constraining makes sense, but we never had that in CDDL anyway. And we retain the type safety for anything that _isn't_ a reference. This resolves issue #31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, it wasn't possible to apply constraints (e.g.
'.size') to references, only directly to Value types. This gives us some
nice type safety (you can't apply '.cbor' to an integer, for example),
it also doesn't allow us to constrain types which are passed as generic
parameters, or where we genuinely want to constrain another rule.
This commit changes that by allowing references (both direct and
generic) to be constrained. Obviously we don't have any guarantees here
that what we are constraining makes sense, but we never had that in CDDL
anyway. And we retain the type safety for anything that isn't a
reference.
This resolves issue #31