-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-617] Move all tests into same folder #1378
[DDW-617] Move all tests into same folder #1378
Conversation
I am reviewing this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DominikGuzei excellent work!
Can you please add the CHANGELOG entry?
Also, I would like to ask you to update the "testing" README file: https://github.com/input-output-hk/daedalus/blob/chore/ddw-617-move-all-tests-into-same-folder/features/README.md
Thanks!
$ yarn test:unit:unbound --tags @mnemonics
yarn run v1.9.4
error Command "test:unit:unbound" not found.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. |
@daniloprates that test is added in a different PR: #1379 |
@daniloprates that description was a mistake 😉 i updated the wrong PR description |
…re/ddw-614-add-unit-tests-for-mnemonics
…tests-for-mnemonics [DDW-614] Add unit tests for mnemonics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As agreed on our weekly call, we need to rename ui
to e2e
tests 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @DominikGuzei - thanks!
This PR refactors and simplifies our test setup:
features
folderfeatures/tests
and contains two sub-folderse2e/unit
for the respective test implementations … (no steps are shared atm)@e2e
and unit tests@unit
yarn test
(build + run all unit and ui tests)yarn test:unit
run all unit tests (those tagged with@unit
)yarn test:unit:watch
only run unit tests with@unit
and@watch
tags and rerun on file changesyarn test:e2e
run all UI tests (app is not built before!)yarn test:e2e:watch
only run tests with@e2e
and@watch
tags (app is built and in watch mode) reruns tests when files changeWhat to test
No QA necessary: Nothing has changed in functionality of the app - only the test setup was refactored.
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn run test
andyarn run test:unit
)yarn run dev
)yarn run package
/ CI builds)yarn run flow:test
)yarn run lint
)yarn run prettier:check
)yarn run manage:translations
produces no changes)yarn run storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board