[DDW-617] Move all tests into same folder

.eslintignore

@@ -6,7 +6,7 @@ logs
 node_modules
 translations
 tests
-features/support/default-wallet.json
+features/tests/e2e/documents/*
 mainnet-genesis-dryrun-with-stakeholders.json
 source/renderer/app/i18n/locales
 nodemon.json

.github/pull_request_template.md

@@ -25,17 +25,17 @@ This PR CHANGES.
 - [ ] PR is updated to the most recent version of the target branch (and there are no conflicts)
 - [ ] PR has a good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
 - [ ] CHANGELOG entry has been added to the top of the appropriate section (*Features*, *Fixes*, *Chores*) and is linked to the correct PR on GitHub
-- [ ] Automated tests: All acceptance  and unit tests are passing (`yarn run test` and `yarn run test:unit`)
-- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *development* build (`yarn run dev`)
-- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *production* build (`yarn run package` / CI builds)
-- [ ] There are no *flow* errors or warnings (`yarn run flow:test`)
-- [ ] There are no *lint* errors or warnings (`yarn run lint`)
-- [ ] There are no *prettier* errors or warnings (`yarn run prettier:check`)
-- [ ] There are no missing translations (running `yarn run manage:translations` produces no changes)
+- [ ] Automated tests: All acceptance and unit tests are passing (`yarn test`)
+- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *development* build (`yarn dev`)
+- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *production* build (`yarn package` / CI builds)
+- [ ] There are no *flow* errors or warnings (`yarn flow:test`)
+- [ ] There are no *lint* errors or warnings (`yarn lint`)
+- [ ] There are no *prettier* errors or warnings (`yarn prettier:check`)
+- [ ] There are no missing translations (running `yarn manage:translations` produces no changes)
 - [ ] Text changes are proofread and approved (Jane Wild / Amy Reeve)
 - [ ] Japanese text changes are proofread and approved (Junko Oda)
 - [ ] UI changes look good in all themes (Alexander Rukin)
-- [ ] Storybook works and no stories are broken (`yarn run storybook`)
+- [ ] Storybook works and no stories are broken (`yarn storybook`)
 - [ ] In case of dependency changes `yarn.lock` file is updated
 
 ### Code Quality

.gitignore

@@ -62,8 +62,8 @@ translations/messages
 translations/reports
 
 # 'Screenshots' and 'Paper wallet ceritifcate PDF file' generated by acceptance tests
-features/support/paper_wallet_certificates/paper-wallet-certificate.pdf
-features/screenshots
+features/tests/e2e/documents/paper_wallet_certificates/paper-wallet-certificate.pdf
+features/tests/e2e/screenshots
 
 # Webpack
 .cache

.prettierignore

@@ -20,4 +20,4 @@
 
 # Ignore the following special folders and files
 source/renderer/app/i18n/locales/
-features/support/default-wallet.json
+features/tests/e2e/documents/*

CHANGELOG.md

@@ -17,6 +17,8 @@ Changelog
 
 ### Chores
 
+- Added unit tests for mnemonic generation and validation ([PR 1379](https://github.com/input-output-hk/daedalus/pull/1379))
+- Simplified the test setup ([PR 1378](https://github.com/input-output-hk/daedalus/pull/1378))
 - Updated PR template ([PR 1376](https://github.com/input-output-hk/daedalus/pull/1376))
 - Implemented new About Us dialog design with a close button ([PR 1369](https://github.com/input-output-hk/daedalus/pull/1369)
 - Refactored store async functions to use mobx runInAction calls ([PR 1367](https://github.com/input-output-hk/daedalus/pull/1367)

features/README.md

@@ -2,35 +2,61 @@
 <sub>Document maintainer: Nikola Glumac<br/>Document status: Active</sub>
 </blockquote>
 
-# Running Daedalus acceptance tests
-
+# Install Daedalus
 
 1. Make sure you have node and yarn installed on your machine
 2. Clone Daedalus repository to your machine (`git clone git@github.com:input-output-hk/daedalus.git`)
 3. Install dependencies from within Daedalus directory:
 
 ```bash
-$ cd daedalus/
 $ yarn install
 ```
 
-4. Build and run the backend (Cardano SL) following the instructions from [Daedalus](https://github.com/input-output-hk/daedalus/blob/master/README.md#development---with-cardano-wallet) README file.
-5. Run Daedalus frontend tests:
+# Run unit tests
+
+Make sure Daedalus is properly installed (see above).
+
+```bash
+$ yarn test:unit
+```
+
+## Unbound tests
+
+Unbound tests run as long as you keep them running 
+(never end except if an error occurs).
+
+Example:
+`yarn test:unit:unbound --tags @mnemonics` 
+generates and validates mnemonics as long as you keep it 
+running (the number of executions is updated in the terminal)
+
+# Run end-to-end tests
+
+1. Make sure Daedalus is properly installed (see above).
+2. Build and run the backend (Cardano SL) following the instructions from [Daedalus](https://github.com/input-output-hk/daedalus/blob/master/README.md#development---with-cardano-wallet) README file.
+3. Run Daedalus frontend tests:
 
 ```bash
 $ cd daedalus/
-$ nix-shell --arg autoStartBackend true --arg systemStart XXX # XXX = cardano system startup time
+$ yarn nix:dev XXX # XXX = cardano system startup time
+$ yarn build
+$ yarn test:e2e
+```
+
+# Run all tests
+
+```bash
 $ yarn test
 ```
 
 Once tests are complete you will get a summary of passed/failed tests in the Terminal window.
 
-## Keeping Daedalus Alive After Tests
+## Keeping Daedalus alive after end-to-end tests
 
 While working on the tests it's often useful to keep Daedalus alive after the tests have run 
 (e.g: to inspect the app state). You can pass a special environment var to tell the test script
 not to close the app:
 
 ````bash
-$ KEEP_APP_AFTER_TESTS=true yarn test
+$ KEEP_APP_AFTER_TESTS=true yarn test:e2e
 ````

features/about-dialog.feature

@@ -1,3 +1,4 @@
+@e2e
 Feature: About Dialog
 
   Background:

features/accept-terms-of-use.feature

@@ -1,3 +1,4 @@
+@e2e
 Feature: Accept "Terms of use"
 
   Background:

features/ada-redemption.feature

@@ -1,3 +1,4 @@
+@e2e
 Feature: Ada Redemption
 
   Background:

features/add-wallet-via-sidebar.feature

@@ -1,3 +1,4 @@
+@e2e
 Feature: Add Wallet via Sidebar
 
   Background:

features/block-consolidation-page.feature

@@ -1,3 +1,4 @@
+@e2e
 Feature: Display Block Consolidation Page
 
   Background:

features/data-layer-migration.feature

@@ -1,3 +1,4 @@
+@e2e
 Feature: Data Layer Migration
 
   Background:

features/delete-wallet-via-settings.feature

@@ -1,3 +1,4 @@
+@e2e
 Feature: Delete Wallet via Settings
 
   Background:

features/import-wallet-via-sidebar.feature

@@ -1,3 +1,4 @@
+@e2e
 Feature: Import Wallet via Sidebar
 
   Background:

features/local-time-difference.feature

@@ -1,3 +1,4 @@
+@e2e
 Feature: Local Time Difference
 
   Scenario: Wrong local time

features/mnemonics-generation-and-validation.feature

@@ -0,0 +1,13 @@
+Feature: Mnemonics generation and validation
+
+  As a developer I want to be sure our mnemonic
+  (12-word recovery phrase) is correctly generated/validated
+
+  @unit @slow
+  Scenario: All generated wallet recovery mnemonics are valid
+    Given I generate 10000 wallet recovery mnemonics
+    Then all generated wallet recovery mnemonics should be valid
+
+  @unbound @mnemonics
+  Scenario: Unbound manual test run gives no invalid mnemeonics
+    Given I generate and validate an unbound number of wallet recovery mnemonics

features/navigate-general-settings-menu.feature

@@ -1,3 +1,4 @@
+@e2e
 Feature: General Settings
 
   Background:

features/navigate-sidebar-categories.feature

@@ -1,3 +1,4 @@
+@e2e
 Feature: Navigate Sidebar Categories
 
   Background:

features/navigate-wallet-tabs.feature

@@ -1,3 +1,4 @@
+@e2e
 Feature: Navigate Wallet Tabs
 
   Background:

features/no-disk-space.feature

@@ -1,3 +1,4 @@
+@e2e
 Feature: No Disk Space Overlay
 
   Background:

features/node-update-exit.feature

@@ -1,3 +1,4 @@
+@e2e
 Feature: Node Update Exit
 
   Background:

features/node-update-notification.feature

@@ -1,3 +1,4 @@
+@e2e
 Feature: Node Update Notification
 
   Background:

features/paper-wallets-certificate.feature

@@ -1,3 +1,4 @@
+@e2e
 Feature: Paper Wallets Certificate generation
 
   Background:

features/quit-app.feature

@@ -1,3 +1,4 @@
+@e2e
 Feature: Quitting Daedalus
 
   Daedalus can be quit in multiple (and unexpected) ways and

features/receive-money.feature

@@ -1,3 +1,4 @@
+@e2e
 Feature: Receive money
 
   Background:

features/restore-wallet-via-sidebar.feature

@@ -1,3 +1,4 @@
+@e2e
 Feature: Add Wallet via Sidebar
 
   Background:

features/select-language.feature

@@ -1,3 +1,4 @@
+@e2e
 Feature: Select Language
 
   Scenario: User Selects Language

features/send-money-to-receiver.feature

@@ -1,3 +1,4 @@
+@e2e
 Feature: Send Money to Receiver
 
   Background:

source/tests/unit/spending-password-validation.feature → features/spending-password-validation.feature

@@ -1,3 +1,4 @@
+@unit
 Feature: Spending password validation
 
   - should contain at least one digit

features/switching-between-wallets.feature

@@ -1,3 +1,4 @@
+@e2e
 Feature: Switching Between Wallets
 
   Background:

features/tests/e2e/documents/default-wallet.json

@@ -0,0 +1,14 @@
+{
+  "wallet": {
+    "accounts": [{ "name": "Genesis account", "index": 2147483648 }],
+    "walletSecretKey": "WIAwbsQgbz9X0WhvOnVeH+yRs7Ri93ESTdMspBHzeLnPUR6hLZL/NazfB40z2x8FZhLwNIt83DCuMR1nGG+ZqvsD/ouyzg3ec729fnrqEMO4A+qPTJmpiRgQZfYO2KDJDRxLtMyofXl90VVZOEke/QddnZ8CGHoR/lCemJgZuvzBpw==",
+    "walletMeta": {
+      "name": "Imported Wallet",
+      "assurance": "normal",
+      "unit": "ADA"
+    },
+    "passwordHash": "WGQxNHw4fDF8V0NERGRHY0JGcThzelVyeFdza00wM1VjYnloeVBBQXBvdWtwdWFsUTExNGVFdz09fFJXMk5kUmVJYmg2REtsa2lsWG8rQ1lvTStRZmJkMzRmRVd0MG4rSy82YUU9"
+  },
+  "fileType": "WALLETS_EXPORT",
+  "fileVersion": "1.0.0"
+}

features/support/helpers/app-helpers.js → features/tests/e2e/helpers/app-helpers.js

@@ -1,6 +1,6 @@
 // @flow
-import type { WebdriverClient } from '../global-types';
-import { getProcessesByName } from '../../../source/main/utils/processes';
+import type { WebdriverClient } from '../setup/global-types';
+import { getProcessesByName } from '../../../../source/main/utils/processes';
 
 export const waitForDaedalusToExit = async (
   client: WebdriverClient,
@@ -15,5 +15,5 @@ export const waitForDaedalusToExit = async (
 };
 
 export const refreshClient = async (client: WebdriverClient) => {
-  await client.url(`file://${__dirname}/../../../dist/renderer/index.html`);
+  await client.url(`file://${__dirname}/../../../../dist/renderer/index.html`);
 };

features/support/helpers/cardano-node-helpers.js → features/tests/e2e/helpers/cardano-node-helpers.js

@@ -1,6 +1,6 @@
 // @flow
-import type { Daedalus, WebdriverClient } from '../global-types';
-import { getProcessesByName } from '../../../source/main/utils/processes';
+import type { Daedalus, WebdriverClient } from '../setup/global-types';
+import { getProcessesByName } from '../../../../source/main/utils/processes';
 
 declare var daedalus: Daedalus;
 

features/support/helpers/notifications-helpers.js → features/tests/e2e/helpers/notifications-helpers.js

@@ -1,4 +1,4 @@
-import { WalletSyncStateTags } from '../../../source/renderer/app/domains/Wallet';
+import { WalletSyncStateTags } from '../../../../source/renderer/app/domains/Wallet';
 
 export const isActiveWalletBeingRestored = async client => {
   const result = await client.execute(

features/support/helpers/screenshot.js → features/tests/e2e/helpers/screenshot.js

@@ -1,10 +1,10 @@
 import fs from 'fs';
 import path from 'path';
-import { generateFileNameWithTimestamp } from '../../../source/common/utils/files';
-import ensureDirectoryExists from '../../../source/main/utils/ensureDirectoryExists';
+import { generateFileNameWithTimestamp } from '../../../../source/common/utils/files';
+import ensureDirectoryExists from '../../../../source/main/utils/ensureDirectoryExists';
 
 export const generateScreenshotFilePath = testName => {
-  const filePath = path.resolve(__dirname, '../../screenshots', testName);
+  const filePath = path.resolve(__dirname, '../screenshots', testName);
   const fileName = generateFileNameWithTimestamp(testName, 'png');
   ensureDirectoryExists(filePath);
   return `${filePath}/${fileName}`;

features/support/electron.js → features/tests/e2e/setup/electron.js

@@ -8,13 +8,13 @@ import {
   setDefaultTimeout,
 } from 'cucumber';
 import electronPath from 'electron';
-import { TEST } from '../../source/common/types/environment.types';
+import { TEST } from '../../../../source/common/types/environment.types';
 import {
   generateScreenshotFilePath,
   getTestNameFromTestFile,
   saveScreenshot,
-} from './helpers/screenshot';
-import { refreshClient } from './helpers/app-helpers';
+} from '../helpers/screenshot';
+import { refreshClient } from '../helpers/app-helpers';
 
 /* eslint-disable consistent-return */
 
@@ -42,8 +42,11 @@ const startApp = async () => {
       NODE_ENV: TEST,
     }),
     waitTimeout: DEFAULT_TIMEOUT,
-    chromeDriverLogPath: path.join(__dirname, '../../logs/chrome-driver.log'),
-    webdriverLogPath: path.join(__dirname, '../../logs/webdriver'),
+    chromeDriverLogPath: path.join(
+      __dirname,
+      '../../../../logs/chrome-driver.log'
+    ),
+    webdriverLogPath: path.join(__dirname, '../../../../logs/webdriver'),
   });
   await app.start();
   await app.client.waitUntilWindowLoaded();

features/support/global-types.js → features/tests/e2e/setup/global-types.js

@@ -1,7 +1,7 @@
 // @flow
-import type { Api } from '../../source/renderer/app/api';
-import type { ActionsMap } from '../../source/renderer/app/actions';
-import type { StoresMap } from '../../source/renderer/app/stores';
+import type { Api } from '../../../../source/renderer/app/api';
+import type { ActionsMap } from '../../../../source/renderer/app/actions';
+import type { StoresMap } from '../../../../source/renderer/app/stores';
 
 export type Daedalus = {
   api: Api,

features/step_definitions/about-dialog.js → features/tests/e2e/steps/about-dialog.js

@@ -1,6 +1,6 @@
 import { Given, When, Then } from 'cucumber';
 import { expect } from 'chai';
-import packageJson from '../../package.json';
+import packageJson from '../../../../package.json';
 
 Given(/^I open the About dialog$/, async function() {
   this.client.execute(() => daedalus.actions.app.openAboutDialog.trigger());

features/step_definitions/accept-terms-of-use-steps.js → features/tests/e2e/steps/accept-terms-of-use-steps.js

@@ -1,6 +1,6 @@
 import { Given, When, Then } from 'cucumber';
 import { expect } from 'chai';
-import termsOfUse from '../support/helpers/terms-of-use-helpers';
+import termsOfUse from '../helpers/terms-of-use-helpers';
 
 const TERMS_OF_USE_FORM = '.TermsOfUseForm_component';