Upgrade to nwb 0.11.0 & fixes #39 (concat vendor/app scripts) #46
Conversation
|
LGTM I want to check if there's a difference between what gets bundled using the |
|
SGTM :) Thanks for taking a look! The one difference I did notice was what appeared to be gzipped files being output to the project root directory. I don't believe I changed anything else here that would cause that but I was unsure if that was an intended default now or something we could turn off (or a bug) :) |
|
Seems fine, but I wasn't able to figure out how |
|
Er, yeah, that sounds weird, I'll check it out locally tonight. |
|
@insin By any chance, were you able to repro what I was seeing? :) I'd be happy to switch back to the |
|
Once we've had a chance to investigate further, I'll update so #39 is tackled. Not super high priority atm. |
|
@insin friendly ping just in case you get a chance to look at this :) If you're busy I can take a look at moving back to |
|
@addyosmani thanks, on my radar again Is there any way to get GitHub's Assigned Issues view to not include |
|
I'm not seeing the gzipped file thing, but there are a couple of other issues I hit which I can add a commit to this branch for. We do not want to switch to |
Fixes: - Location of sw-toolbox.js appears to have changed, so fixed it - Add babel and babel-core dependencies (=nwb versions) to fix server.js with npm2 Tweaks: - Use node_modules/.bin/ scripts instead of absolute path to tool CLI scripts - Lint server.js - Pinned and sorted dependencies
|
@insin I think you might be able to use a bookmark to get the desired filtering there. For example this gives you the view you were after I believe. If I misunderstood, holler 📯 Thanks for the extra commits and tweaks to this branch! Looks like it requires a little rebasing against master. Will take a look at that. |
| "serve": "./node_modules/.bin/nwb serve", | ||
| "precache": "./node_modules/sw-precache/cli.js --root=public --config=sw-precache-config.json" | ||
| "serve": "nwb serve", | ||
| "precache": "sw-precache --root=public --config=sw-precache-config.json" | ||
| }, |
There was a problem hiding this comment.
I think I may have needed to use these paths to get the Node on GAE deploys happy again. I'll try it out with these changes and see if we run into any trouble at all.
|
I genuinely forgot that bookmarks are A Thing 😜 |
|
Haha. Okay, soooo..updated this to a merge-friendly state. Local builds are all good. I am still seeing those mysterious .json.gzip files in my builds, even with latest
Otherwise looks good to go. |
|
It looks like those are caused by the |
|
Cheers for the info! Is there a way we could explicitly set |
|
Are you running as root? Searching around it seems like that results in the cwd being the temp dir. Edit: npm/npm#4531 |
|
Ah. That may well be it. I'm working on a Goog corp machine with some extra root weirdness applied to |
|
This PR has been replaced with the work that just landed in master updating us to more recent versions of nwb and deps as well as adding in route-based code-splitting. Closing this partic PR off as it's outdated now. |
This patchset upgrades us to the latest version of
nwband also moves us over to async loading in the single bundle generated byvendorBundle: false.