Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to nwb 0.11.0 & fixes #39 (concat vendor/app scripts) #46

Closed
wants to merge 6 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,37 +9,39 @@
"url": "http://github.com/insin/react-hn.git"
},
"scripts": {
"build": "npm run lint && cp node_modules/sw-toolbox/build/sw-toolbox.js public/sw-toolbox.js && ./node_modules/.bin/react build src/index.js public/build && npm run precache",
"build": "npm run lint && cp node_modules/sw-toolbox/sw-toolbox.js public/sw-toolbox.js && react build src/index.js public/build && npm run precache",
"deploy": "gcloud preview app deploy",
"lint": "./node_modules/eslint-config-jonnybuchanan/bin/lint.js src",
"lint:fix": "./node_modules/eslint-config-jonnybuchanan/bin/lint.js --fix .",
"lint": "eslint src server.js",
"lint:fix": "npm run lint -- --fix",
"start": "node server.js",
"postinstall": "npm run build",
"serve": "./node_modules/.bin/nwb serve",
"precache": "./node_modules/sw-precache/cli.js --root=public --config=sw-precache-config.json"
"serve": "nwb serve",
"precache": "sw-precache --root=public --config=sw-precache-config.json"
},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I may have needed to use these paths to get the Node on GAE deploys happy again. I'll try it out with these changes and see if we run into any trouble at all.

"engines": {
"node": "6.1.0"
},
"main": "server.js",
"dependencies": {
"ejs": "^2.4.1",
"babel": "5.8.38",
"babel-core": "5.8.38",
"ejs": "2.4.2",
"eslint-config-jonnybuchanan": "2.0.3",
"events": "1.1.0",
"express": "^4.13.4",
"express": "4.14.0",
"firebase": "2.4.2",
"history": "2.1.1",
"isomorphic-fetch": "^2.2.1",
"isomorphic-fetch": "2.2.1",
"nwb": "0.11.0",
"react": "15.0.2",
"react-dom": "15.0.2",
"react-router": "2.4.0",
"react-timeago": "3.0.0",
"reactfire": "0.7.0",
"scroll-behavior": "0.5.0",
"setimmediate": "1.0.4",
"url-parse": "^1.1.1",
"eslint-config-jonnybuchanan": "2.0.3",
"nwb": "0.11.0",
"sw-precache": "^3.1.1",
"sw-toolbox": "^3.1.1"
"sw-precache": "3.2.0",
"sw-toolbox": "3.2.1",
"url-parse": "1.1.1"
}
}