Merge pull request #120 from chef/BP-219/hide-ssh-password-in-logs

do not log password in ssh connection output

lib/train/transports/ssh_connection.rb

@@ -216,7 +216,9 @@ def session(retry_options = {})
     #
     # @api private
     def to_s
-      "#{@username}@#{@hostname}<#{@options.inspect}>"
+      options_to_print = @options.clone
+      options_to_print[:password] = '<hidden>' if options_to_print.key?(:password)
+      "#{@username}@#{@hostname}<#{options_to_print.inspect}>"
     end
 
     class OS < OSCommon

test/unit/transports/ssh_test.rb

@@ -82,6 +82,15 @@ def detect_family
     end
   end
 
+  describe 'converting connection to string for logging' do
+   it "masks passwords" do
+      assert_output(/.*:password=>"<hidden>".*/) do
+        connection = cls.new(conf).connection
+        puts "#{connection}"
+      end
+    end
+  end
+
   describe 'failed configuration' do
     it 'works with a minimum valid config' do
       cls.new(conf).connection