Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not log password in ssh connection output #120

Merged
merged 2 commits into from
Jun 28, 2016

Conversation

marcparadise
Copy link
Contributor

This addresses an immediate need for delivery CLIP, but a better longer-term approach may be to make something like:

class ConnectionOptions < Hash 
  def to_s
    # find any  key => .*password.* with value type String  here and obscure them. 
  end
end

I didn't take that for this change because it'd be a mid-sized refactor.

ping @arlimus @srenatus

A longer-term approach may be to refactor Options to be a class
insteaad of a simple hash, so that this can be applied across all transports.
@arlimus
Copy link
Contributor

arlimus commented Jun 27, 2016

Awesome! Could you please help with the linting errors and we'll get this merged :)

@srenatus
Copy link
Contributor

LGTM! 🎉

@srenatus srenatus merged commit 2fc29b3 into master Jun 28, 2016
@srenatus srenatus deleted the BP-219/hide-ssh-password-in-logs branch June 28, 2016 10:07
@srenatus
Copy link
Contributor

Thanks a lot, @marcparadise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants