Skip to content

Commit

Permalink
Merge pull request #753 from inspec/ss/remove-coveralls
Browse files Browse the repository at this point in the history
Remove dependency on `coveralls` gem from train
  • Loading branch information
Vasu1105 authored Oct 12, 2023
2 parents 9c90ec3 + 2e3517c commit c6664e4
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 20 deletions.
35 changes: 22 additions & 13 deletions .expeditor/coverage.pipeline.yml
Original file line number Diff line number Diff line change
@@ -1,19 +1,28 @@
---
# TODO: Update pipeline when we introduce the coverage pipeline

steps:
- label: coverage
commands:
- /workdir/.expeditor/buildkite/coverage.sh
- label: "placeholder-for-coverage-pipeline"
expeditor:
secrets:
COVERALLS_REPO_TOKEN:
path: secret/coveralls/inspec/train
field: repo_token
executor:
docker:
environment:
- CI_ENABLE_COVERAGE=true
- CI_NAME=Buildkite
- CI_BUILD_NUMBER=$BUILDKITE_BUILD_NUMBER
- CI_BUILD_URL=$BUILDKITE_BUILD_URL
- CI_BRANCH=$BUILDKITE_BRANCH
commands:
- "echo ## This pipeline does nothing. Implement the coverage pipeline in near future."

# steps:
# - label: coverage
# commands:
# - /workdir/.expeditor/buildkite/coverage.sh
# expeditor:
# secrets:
# COVERALLS_REPO_TOKEN:
# path: secret/coveralls/inspec/train
# field: repo_token
# executor:
# docker:
# environment:
# - CI_ENABLE_COVERAGE=true
# - CI_NAME=Buildkite
# - CI_BUILD_NUMBER=$BUILDKITE_BUILD_NUMBER
# - CI_BUILD_URL=$BUILDKITE_BUILD_URL
# - CI_BRANCH=$BUILDKITE_BRANCH
1 change: 0 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ if Gem.ruby_version.to_s.start_with?("2.5")
end

group :test do
gem "coveralls", require: false
gem "minitest", "~> 5.8"
gem "rake", "~> 13.0"
gem "chefstyle", "2.1.1"
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ For more information on project states and SLAs, see [this documentation](https:

[![Build status](https://badge.buildkite.com/ee9d6f49d995b23e943955b12d5aaadf4314d12b7cc99b03be.svg?branch=master)](https://buildkite.com/chef-oss/inspec-train-master-verify)
[![Gem Version](https://badge.fury.io/rb/train.svg)](https://badge.fury.io/rb/train)
[![Coverage Status](https://coveralls.io/repos/github/inspec/train/badge.svg?branch=master)](https://coveralls.io/github/inspec/train?branch=master)

**Umbrella Project**: [Chef Foundation](https://github.com/chef/chef-oss-practices/blob/master/projects/chef-foundation.md)

Expand Down
2 changes: 0 additions & 2 deletions test/helper.rb
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
if ENV["CI_ENABLE_COVERAGE"]
require "simplecov"
require "coveralls"
SimpleCov.formatters = SimpleCov::Formatter::MultiFormatter.new([
SimpleCov::Formatter::HTMLFormatter,
Coveralls::SimpleCov::Formatter,
])

SimpleCov.start do
Expand Down
3 changes: 0 additions & 3 deletions test/integration/helper.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
require "coveralls"
Coveralls.wear!

require "minitest/autorun"
require "minitest/spec"

Expand Down

0 comments on commit c6664e4

Please sign in to comment.