Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on coveralls gem from train #753

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

ahasunos
Copy link
Contributor

@ahasunos ahasunos commented Oct 12, 2023

Description

This PR removes the dependency on coveralls. We no longer use coveralls for our coverage pipeline.

Dependency on coveralls is breaking the verify pipeline for Ruby 3.0

We will implement this pipeline in near future.

Reverts - #440

Related Issue

https://buildkite.com/chef-oss/inspec-train-main-verify/builds/888#018b241a-d0da-4c45-afa8-562cac70d8ee

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

Signed-off-by: Sonu Saha <sonu.saha@progress.com>
@ahasunos ahasunos requested a review from a team as a code owner October 12, 2023 13:52
@ahasunos ahasunos requested review from Vasu1105 and Nik08 October 12, 2023 13:52
@Vasu1105
Copy link
Contributor

This looks good to me. Going ahead and merging this.

@Vasu1105 Vasu1105 merged commit c6664e4 into main Oct 12, 2023
1 check passed
chef-expeditor bot pushed a commit that referenced this pull request Oct 12, 2023
Obvious fix; these changes are the result of automation not creative thinking.
@ahasunos ahasunos deleted the ss/remove-coveralls branch April 15, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants