-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fallback regex for OpenSuse #451
Conversation
@n-rodriguez Can you add a comment above the regex with a permalink from rubular. https://rubular.com/ That way we can have a link in the code to show the various things we're trying to match instead of having to track things back to this PR. Also you'll need to sign this commit off for the DCO before we can merge it. https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco |
@tas50 done! Thank you! |
Seems OK with more variants: https://rubular.com/r/b5PN3hZDxa5amV And an example for the regex appearing above it: https://rubular.com/r/UKaYWolCYFMfp1 |
Signed-off-by: Nicolas Rodriguez <nicoladmin@free.fr>
@robbkidd done! thank you! 👍 |
I dunno... should I be the anal-retentive regexp-er? I am not sure it actually matters because this is coming from some vendored source? I'm gonna approve, but just so you know, that |
Actually |
I meant |
Ok. Do you want me to change it? |
I'll get it. Just consider it for next time. |
I'll remember! Thanks! |
* `train` gem has been fixed upstream - inspec/train#451 - https://rubygems.org/gems/train/versions/2.1.7
* `train` gem has been fixed upstream - inspec/train#451 - https://rubygems.org/gems/train/versions/2.1.7
See #377
This regex matches both case :
VERSION = 15.0
andVERSION="15.0"
Thank you!