ci(kichen+travis): test with pre-salted Docker images #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myii
requested changes
May 13, 2019
There was a problem hiding this comment.
Excellent start. Will need to update https://github.com/saltstack-formulas/systemd-formula/blob/master/test/integration/default/inspec.yml in order to get inspec tests running on all platforms. For example, no tests running here:
|
It's only one of them ( |
|
@n-rodriguez can't see why this would fail only on opensuse 15.0, next entered the container: so it should work... |
aboe76
approved these changes
May 14, 2019
it might be a bug within inspec... |
no... systemd-network was not enabled : |
|
@n-rodriguez the issue is an Running it locally you can see that |
|
@javierbertoli thanks for finding this. |
|
well... that's weird... nicolas@cloud:~/SALT/ufw-formula$ bundle exec kitchen login default-opensuse-leap-15-2019-2-py3
Last login: Wed May 15 19:17:33 2019 from 172.17.0.1
Have a lot of fun...
kitchen@ab3c49a5edd3:~> cat /etc/SuSE-release
NAME="openSUSE Leap"
VERSION="15.0"
ID="opensuse-leap"
ID_LIKE="suse opensuse"
VERSION_ID="15.0"
PRETTY_NAME="openSUSE Leap 15.0"
ANSI_COLOR="0;32"
CPE_NAME="cpe:/o:opensuse:leap:15.0"
BUG_REPORT_URL="https://bugs.opensuse.org"
HOME_URL="https://www.opensuse.org/"
kitchen@ab3c49a5edd3:~> |
nicolas@cloud:~/SALT/systemd-formula$ bundle exec kitchen verify default-opensuse-leap-15-2019-2-py3
-----> Starting Kitchen (v2.2.4)
-----> Verifying <default-opensuse-leap-15-2019-2-py3>...
[2019-05-15T21:38:59+02:00] WARN: DEPRECATION: InSpec Attributes are being renamed to InSpec Inputs to avoid confusion with Chef Attributes. Use --input-file on the command line instead of --attrs.
Loaded systemd
[2019-05-15T21:39:01+02:00] WARN: DEPRECATION: The service `be_running?` matcher is deprecated. This is only allowed for compatibility with ServerSpec (used at /data/nicolas/SALT/systemd-formula/test/integration/default/controls/networkd_spec.rb:48)
e
Profile: Systemd Formula (systemd)
Version: (not specified)
Target: ssh://kitchen@localhost:32778
✔ Systemd units: should match desired lines
✔ File /etc/systemd/system/syncthing-someuser.service type should eq :file
✔ File /etc/systemd/system/syncthing-someuser.service mode should cmp == "0644"
✔ File /etc/systemd/system/syncthing-someuser.service owner should eq "root"
✔ File /etc/systemd/system/syncthing-someuser.service group should eq "root"
✔ Service syncthing-someuser.service should be enabled
✔ Systemd Networkd: should match desired lines
✔ File /etc/systemd/network type should eq :directory
✔ File /etc/systemd/network mode should cmp == "0755"
✔ File /etc/systemd/network owner should eq "root"
✔ File /etc/systemd/network group should eq "root"
✔ File /etc/systemd/network/99-default.link type should eq :file
✔ File /etc/systemd/network/99-default.link mode should cmp == "0644"
✔ File /etc/systemd/network/99-default.link owner should eq "root"
✔ File /etc/systemd/network/99-default.link group should eq "root"
✔ File /etc/systemd/network/eth0.network type should eq :file
✔ File /etc/systemd/network/eth0.network mode should cmp == "0644"
✔ File /etc/systemd/network/eth0.network owner should eq "root"
✔ File /etc/systemd/network/eth0.network group should eq "root"
✔ File /etc/systemd/network/br0.netdev type should eq :file
✔ File /etc/systemd/network/br0.netdev mode should cmp == "0644"
✔ File /etc/systemd/network/br0.netdev owner should eq "root"
✔ File /etc/systemd/network/br0.netdev group should eq "root"
✔ File /etc/systemd/network/10-dmz.link type should eq :file
✔ File /etc/systemd/network/10-dmz.link mode should cmp == "0644"
✔ File /etc/systemd/network/10-dmz.link owner should eq "root"
✔ File /etc/systemd/network/10-dmz.link group should eq "root"
✔ File /etc/systemd/network/10-internet.link type should eq :file
✔ File /etc/systemd/network/10-internet.link mode should cmp == "0644"
✔ File /etc/systemd/network/10-internet.link owner should eq "root"
✔ File /etc/systemd/network/10-internet.link group should eq "root"
✔ Service systemd-networkd should be enabled
✔ Service systemd-networkd should be running
✔ Service systemd-networkd-wait-online should be enabled
✔ Systemd package: should be installed
✔ System Package systemd should be installed
Profile Summary: 3 successful controls, 0 control failures, 0 controls skipped
Test Summary: 33 successful, 0 failures, 0 skipped
Finished verifying <default-opensuse-leap-15-2019-2-py3> (0m3.54s).
-----> Kitchen is finished. (0m5.27s)
nicolas@cloud:~/SALT/systemd-formula$ |
|
Great work @n-rodriguez! |
|
@n-rodriguez nice find |
|
@n-rodriguez and @myii can we merge this one? |
myii
requested changes
May 22, 2019
I'd like to, but I'm waiting for release 2.1.6 of train on rubygems. |
myii
approved these changes
May 23, 2019
|
@n-rodriguez Merged, thanks for this PR and for fixing |
|
🎉 This PR is included in version 0.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.