Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail with Nokogiri 1.13.7 #12

Open
radar opened this issue Jul 13, 2022 · 1 comment
Open

Tests fail with Nokogiri 1.13.7 #12

radar opened this issue Jul 13, 2022 · 1 comment

Comments

@radar
Copy link

radar commented Jul 13, 2022

      TypeError:
        wrong argument type Nokogiri::XML::Element (expected Data)
      # ./lib/xmlsec.rb:7:in `sign!'
      # ./lib/xmlsec.rb:7:in `sign!'
      # ./spec/lib/nokogiri/xml/document/unsafe_xml_spec.rb:43:in `block (3 levels) in <top (required)>'

  58) unsafe xml guards: XML Signature URI does allow same document signing references
      Failure/Error: root.sign! opts

      TypeError:
        wrong argument type Nokogiri::XML::Element (expected Data)
      # ./lib/xmlsec.rb:7:in `sign!'
      # ./lib/xmlsec.rb:7:in `sign!'
      # ./spec/lib/nokogiri/xml/document/unsafe_xml_spec.rb:53:in `block (3 levels) in <top (required)>'

Just posting this here so you're aware.

I'll see if I can get a fix through.

Possibly related to #9?

radar added a commit to radar/nokogiri-xmlsec-instructure that referenced this issue Jul 13, 2022
radar added a commit to radar/nokogiri-xmlsec-instructure that referenced this issue Jul 13, 2022
@flavorjones
Copy link

👋 nokogiri maintainer here.

I wasn't aware of how much this gem (and potentially others) are relying on nokogiri internals. I've added this gem to our downstream test suite in sparklemotion/nokogiri#2595 so I'm aware of breakage that's being introduced.

I'd also like to offer up a PR to fix this ... give me a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants