fix: support Nokogiri >= 1.13.7 #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which changed the typed-data semantics around xmlNode in order to fully support compaction see sparklemotion/nokogiri#2579
|
|
This was referenced Jul 13, 2022
|
Bumping this in case maintainers want to pull it in. |
|
👍 FWIW we'll also be integration testing against this repo going forward, see sparklemotion/nokogiri#2595 |
|
@flavorjones That sounds great! Sadly what this gem does is definitely kinda gross by extending a c extension with another c extension and attempting to work with the datastructures of the base c extension, not purely the datastructures of libxml itself. I don't know if there's a better pattern to use for doing what this gem does, but if you (or anyone else) happens to know of one I'd be happy to look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12
Nokogiri 1.13.7 changed the typed-data semantics around xmlNode in order to
fully support compaction
see sparklemotion/nokogiri#2579
I've tested this with older versions of Nokogiri, it's backwards-compatible.
However, reproducing
Noko_Node_Get_Structin this project is hacky. Perhaps in a future PR I can help find and compile againstnokogiri.hwhich is findable viaNokogiri::VERSION_INFOmetadata (cppflags). Let me know if that would be welcome.