Optional aggregation control #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aulemahal let me know when this is ready for review - happy to take a look. I think this approach makes sense. |
|
@aulemahal - following up here, is this ready for review? |
|
Sorry, I haven't had time to put on this in the last days. I still need to merge the conflicts and to add tests. I may have time in the next few days! |
|
No worries - take your time! I just wanted to check in and see if I could help with anything |
mgrover1
reviewed
Mar 16, 2023
Co-authored-by: Max Grover <mgroverwx@gmail.com>
|
This is finally ready for review @mgrover1 ! |
andersy005
reviewed
May 10, 2023
|
Here we go. While investigating the weird conditionnal, I realized that method was broken. Fixing it made me discover another deeper bug... So here we are with another implementation of the no-agg groups construction, which I believe is somewhat simpler. |
mgrover1
approved these changes
May 11, 2023
tlvu
added a commit
to Ouranosinc/PAVICS-e2e-workflow-tests
that referenced
this pull request
Aug 30, 2023
Should be fixed by intake/intake-esm#569. Fixes #109
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
cat.esmcat.aggregation_controlis None.Related issue number
Checklist
I added a few tests, but maybe I should add more to test most of the normal operations with a catalog missing the aggregation control.